Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Created flag for .root kinematics input file. #1760

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jackal1-66
Copy link
Collaborator

This PR is related to the ticket https://its.cern.ch/jira/browse/O2-5216
It has been tested locally and the feature works as expected.
Check the ticket for more information.
The approval of this PR is strictly connected to this other AliceO2Group/AliceO2#13571

Copy link

github-actions bot commented Oct 7, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@jackal1-66 jackal1-66 changed the title [WIP] Created flag for .root Kinematics input file. [WIP] Created flag for .root kinematics input file. Oct 7, 2024
@@ -56,6 +56,7 @@
parser.add_argument('--cpu-limit', help='Set CPU limit (core count)', default=8, type=float)
parser.add_argument('--cgroup', help='Execute pipeline under a given cgroup (e.g., 8coregrid) emulating resource constraints. This m\
ust exist and the tasks file must be writable to with the current user.')
parser.add_argument('--kine-input', help='Use pre-existent event generation.', default="", type=str)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not putting such treatment in the workflow runner because the runner shouldn't know about what it is running (just some topology).

Let's rather put such a flag in the actual MC workflow script generation part.
Or we provide a dedicated generator which will just do this and simply call this generator with existing flag --gen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants