Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIDML] use dynamic columns instead of hardcoding #10282

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

[PIDML] use dynamic columns instead of hardcoding #10282

wants to merge 22 commits into from

Conversation

mytkom
Copy link
Contributor

@mytkom mytkom commented Mar 2, 2025

No description provided.

mytkom and others added 17 commits February 28, 2025 10:27
@mytkom
use dynamic columns from JSON file instead of hardcoding them
2ebea7b
@mytkom
formatting
be9b9d3
@mytkom
add missing includes
f663180
@mytkom
use getIterator - no more passing of table
d7e6267
@mytkom
comment out tracks table in KaonPidTask
0261ffb
@mytkom
refactor solution to be more generic
af0b48a
@mytkom
move out common condition
e401894
@mytkom
remove unused methods from ONNXModel and simplify is_equal_size function
488a718
@mytkom
tidy up pidEffAndPurProducer
75f424c
@mytkom
remove unused include
e3d9a1a
@mytkom
remove more unused includes
f213494
@mytkom
add include to ONNXModel
737435b
@mytkom
use getGetterByLabel (not merged to O2Framework yet) as proof of concept
10edefd
@mytkom
add missing includes
49cd2fa
@alibuild @mytkom
Please consider the following formatting changes (#14)
a5f0f8e
@mytkom
satisfy all o2_linter.py requirements and delete KaonPidTask (no one …
c0a855d 
…is using it according to Shirajum Monira)
@mytkom
fix compilation
f3a7577
@mytkom mytkom requested review from alibuild and saganatt as code owners March 2, 2025 20:33
@alibuild
Copy link
Collaborator

alibuild commented Mar 2, 2025

Error while checking build/O2Physics/o2 for 2ddbbe1 at 2025-03-02 23:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:364:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:402:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/10282-slc9_x86-64/0/Tools/PIDML/qaPid.cxx:412:23: error: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt saganatt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mytkom @alibuild