-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGHF: fix generated candidate flagging & add cand. creator MC process w/o centrality sel. #6967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please consider the following formatting changes to AliceO2Group#6967
fgrosa
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stefanopolitano, I still have a couple of comments, please see below. Thanks!
Please consider the following formatting changes to AliceO2Group#6967
stefanopolitano
requested review from
alibuild,
vkucera,
fcolamar,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
nzardosh,
NicoleBastid,
hahassan7 and
jpxrk
as code owners
July 24, 2024 13:42
fgrosa
approved these changes
Jul 24, 2024
MaximVirta
pushed a commit
to MaximVirta/O2Physics
that referenced
this pull request
Aug 5, 2024
…s w/o centrality sel. (AliceO2Group#6967) * PWGHF: fix generated candidate flagging in cand. creator * PWGHF: adding MC process function in candidate crator w/o centrality selection * Please consider the following formatting changes * PWGHF: addressing comments, adding init protection and enabling default process function * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of candidates from bkg events to avoid rejecting them, but flagging them as bkg and adds process functions for MC to create candidates w/o centrality selection