Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added three-particle correlations task #6988

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Added three-particle correlations task #6988

merged 5 commits into from
Aug 2, 2024

Conversation

JStaa
Copy link
Contributor

@JStaa JStaa commented Jul 25, 2024

No description provided.

@alibuild alibuild mentioned this pull request Jul 25, 2024
Merged
JStaa added a commit to JStaa/O2Physics that referenced this pull request Jul 25, 2024
@JStaa
Merge pull request #2 from alibuild/alibot-cleanup-6988
fd2f955 
Please consider the following formatting changes to AliceO2Group#6988
victor-gonzalez
victor-gonzalez requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving forward this functionality!
As O2Analysis and Task are implicit from the position in the source tree, please rename the source file as just ThreeParticleCorrelations.cxx

PWGCF/MultiparticleCorrelations/Tasks/O2AnalysisTaskThreePartCorr.cxx Outdated Show resolved Hide resolved
PWGCF/MultiparticleCorrelations/Tasks/O2AnalysisTaskThreePartCorr.cxx Outdated Show resolved Hide resolved
PWGCF/MultiparticleCorrelations/Tasks/O2AnalysisTaskThreePartCorr.cxx Outdated Show resolved Hide resolved
PWGCF/MultiparticleCorrelations/Tasks/O2AnalysisTaskThreePartCorr.cxx Outdated Show resolved Hide resolved
@JStaa JStaa closed this Jul 26, 2024
@victor-gonzalez victor-gonzalez mentioned this pull request Jul 30, 2024
Closed
@JStaa JStaa reopened this Jul 31, 2024
@JStaa JStaa changed the title Added Three-particle correlations task Added three-particle correlations task Jul 31, 2024
victor-gonzalez
victor-gonzalez previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please, have a look at my suggestions for the next iteration in case you wanted to consider them

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 1a113ee at 2024-07-31 15:26:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6988-slc7_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/ThreeParticleCorrelations.cxx:177:49: error: unused parameter 'collisions' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/6988-slc7_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/ThreeParticleCorrelations.cxx:177:82: error: unused parameter 'v0s' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/6988-slc7_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/ThreeParticleCorrelations.cxx:177:111: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/6988-slc7_x86-64/0/PWGCF/MultiparticleCorrelations/Tasks/ThreeParticleCorrelations.cxx:270:3: error: control reaches end of non-void function [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Jul 31, 2024
Merged
JStaa added a commit to JStaa/O2Physics that referenced this pull request Jul 31, 2024
@JStaa
Merge pull request #5 from alibuild/alibot-cleanup-6988
18948f5 
Please consider the following formatting changes to AliceO2Group#6988
victor-gonzalez
victor-gonzalez requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler errors haven't been fixed (not all of them, at least), it will fail again

@alibuild alibuild mentioned this pull request Aug 1, 2024
Merged
@JStaa
Merge pull request #6 from alibuild/alibot-cleanup-6988
19daafe 
Please consider the following formatting changes to AliceO2Group#6988
@victor-gonzalez victor-gonzalez merged commit 1a2c6e7 into AliceO2Group:master Aug 2, 2024
9 of 10 checks passed
MaximVirta pushed a commit to MaximVirta/O2Physics that referenced this pull request Aug 5, 2024
@JStaa @alibuild @MaximVirta
Added three-particle correlations task (AliceO2Group#6988)
5edfaff 
* Added revised three-particle correlation function

* Added a null output to V0Sign()

* Added a LOGF-statement in processMixed()

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <[email protected]>
Luca610 pushed a commit to Luca610/O2Physics that referenced this pull request Aug 13, 2024
@JStaa @alibuild @Luca610
Added three-particle correlations task (AliceO2Group#6988)
2b54579 
* Added revised three-particle correlation function

* Added a null output to V0Sign()

* Added a LOGF-statement in processMixed()

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <[email protected]>
joonsukbae pushed a commit to joonsukbae/O2Physics that referenced this pull request Aug 27, 2024
@JStaa @alibuild @joonsukbae
Added three-particle correlations task (AliceO2Group#6988)
98cc22f 
* Added revised three-particle correlation function

* Added a null output to V0Sign()

* Added a LOGF-statement in processMixed()

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt saganatt is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JStaa @alibuild @victor-gonzalez