Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper lnn mass #7053

Merged
merged 12 commits into from
Aug 2, 2024
Merged

Add proper lnn mass #7053

merged 12 commits into from
Aug 2, 2024

Conversation

mapalhares
Copy link
Contributor

No description provided.

@alibuild alibuild mentioned this pull request Jul 30, 2024
Merged
mapalhares added a commit to mapalhares/O2Physics that referenced this pull request Jul 30, 2024
@mapalhares
Merge pull request #19 from alibuild/alibot-cleanup-7053
4fa4820 
Please consider the following formatting changes to AliceO2Group#7053
chiarapinto
chiarapinto previously approved these changes Jul 30, 2024
View reviewed changes
@chiarapinto chiarapinto enabled auto-merge (squash) July 30, 2024 09:17
@vkucera
Copy link
Collaborator

vkucera commented Jul 30, 2024

There is a bug in the event selection, reported by the compiler.

auto-merge was automatically disabled July 31, 2024 11:45

Head branch was pushed to by a user without write access

This was referenced Jul 31, 2024
Merged
Merged
mapalhares added a commit to mapalhares/O2Physics that referenced this pull request Jul 31, 2024
@mapalhares
Merge pull request #21 from alibuild/alibot-cleanup-7053
2da7be6 
Please consider the following formatting changes to AliceO2Group#7053
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 2da7be6 at 2024-07-31 14:32:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7053-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/lnnRecoTask.cxx:507:5: error: 'IsGoodCollision' was not declared in this scope; did you mean 'isGoodCollision'?
/sw/SOURCES/O2Physics/7053-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/lnnRecoTask.cxx:504:79: error: unused parameter 'mcCollisions' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Jul 31, 2024
Merged
mapalhares added a commit to mapalhares/O2Physics that referenced this pull request Jul 31, 2024
@mapalhares
Merge pull request #22 from alibuild/alibot-cleanup-7053
a9ca27b 
Please consider the following formatting changes to AliceO2Group#7053
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for a9ca27b at 2024-07-31 16:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7053-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/lnnRecoTask.cxx:508:7: error: expected ';' before 'isGoodCollision'
/sw/SOURCES/O2Physics/7053-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/lnnRecoTask.cxx:504:79: error: unused parameter 'mcCollisions' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Jul 31, 2024
Merged
@mapalhares
Merge pull request #23 from alibuild/alibot-cleanup-7053
fbe6014 
Please consider the following formatting changes to AliceO2Group#7053
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for fbe6014 at 2024-07-31 19:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7053-slc7_x86-64/0/PWGLF/TableProducer/Nuspex/lnnRecoTask.cxx:126:58: error: narrowing conversion of '7.0000000000000007e-2' from 'double' to 'bool' [-Wnarrowing]
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:139:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/O2/daily-20240731-0200-local1/include/Framework/StructToTuple.h:287:29: error: static assertion failed: Too many elements in the struct
/sw/slc7_x86-64/GCC-Toolchain/v12.2.0-alice1-local1/include/c++/12.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(lnnRecoTask*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Aug 1, 2024
Merged
@mpuccio mpuccio enabled auto-merge (squash) August 2, 2024 11:38
@mpuccio mpuccio merged commit 3b0a0e5 into AliceO2Group:master Aug 2, 2024
10 checks passed
vkucera
vkucera reviewed Aug 2, 2024
View reviewed changes
PWGLF/TableProducer/Nuspex/lnnRecoTask.cxx
Comment on lines -516 to +529
if (std::abs(collision.posZ()) > 10) {
if ((collision.posZ()) > 10) {
Copy link
Collaborator

@vkucera vkucera Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mapalhares @fmazzasc I think this is still a bug.

MaximVirta pushed a commit to MaximVirta/O2Physics that referenced this pull request Aug 5, 2024
@mapalhares @MaximVirta
Add proper lnn mass (AliceO2Group#7053)
2827632
Luca610 pushed a commit to Luca610/O2Physics that referenced this pull request Aug 13, 2024
@mapalhares @Luca610
Add proper lnn mass (AliceO2Group#7053)
519e1a6
joonsukbae pushed a commit to joonsukbae/O2Physics that referenced this pull request Aug 27, 2024
@mapalhares @joonsukbae
Add proper lnn mass (AliceO2Group#7053)
e939e00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkucera vkucera vkucera left review comments

@fmazzasc fmazzasc fmazzasc approved these changes

@chiarapinto chiarapinto chiarapinto left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@BongHwi BongHwi Awaiting requested review from BongHwi BongHwi is a code owner

@mbombara mbombara Awaiting requested review from mbombara

@ChiaraDeMartin95 ChiaraDeMartin95 Awaiting requested review from ChiaraDeMartin95 ChiaraDeMartin95 is a code owner

@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mapalhares @vkucera @alibuild @fmazzasc @chiarapinto @mpuccio