Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGEM]: Add CutSetting with 30 cut variations #7190

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[PWGEM]: Add CutSetting with 30 cut variations #7190

merged 1 commit into from
Aug 7, 2024

Conversation

feisenhu
Copy link
Collaborator

@feisenhu feisenhu commented Aug 6, 2024

Adding setting of cut variations.

dsekihat
dsekihat reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@dsekihat dsekihat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Florian, do you really need 30 hardcoded variations? You should think about other better ways.

@feisenhu feisenhu enabled auto-merge (squash) August 7, 2024 11:49
alibuild
alibuild approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @feisenhu.

@feisenhu feisenhu merged commit 24b47db into AliceO2Group:master Aug 7, 2024
11 checks passed
Luca610 pushed a commit to Luca610/O2Physics that referenced this pull request Aug 13, 2024
@feisenhu @Luca610
[PWGEM]: Add CutSetting with 30 cut variations (AliceO2Group#7190)
de7192b
joonsukbae pushed a commit to joonsukbae/O2Physics that referenced this pull request Aug 27, 2024
@feisenhu @joonsukbae
[PWGEM]: Add CutSetting with 30 cut variations (AliceO2Group#7190)
04ea6cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsekihat dsekihat dsekihat left review comments

@alibuild alibuild alibuild approved these changes

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feisenhu @alibuild @dsekihat