-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(QVecDev) Added tables with new labeling #7199
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use proper camelCase for good readability.
Qvec
,Cpos
,Cneg
,Call
are not words nor abbreviations.This applies to all other name changes too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the "Qvec" -> "QVec" part, I would prefer not to change those as there are many tasks which are already dependent on these labeling and would need to be changed as well. The "TPCpos" -> "TpcPos" I can change, but why should we change only TPC to be in lower case, when other detectors are in capitals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would "TPCPos" be a better option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR itself is titled
QVecDev
, includes filesqVectorsTable.cxx
,qVectorsCorrection.cxx
, and defines variables likeqVectorBPosVec
. So apparently the capitalisation ofv
is very common in your code and not an issue. So I would say that the occurrences of lower-casev
(e.g.Qvectors.h
) should be fixed to avoid inconsistencies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerning the capitalisation of TPC, while it might be fine at the beginning of a word, it becomes less readable when in the middle of the word and very unreadable when combined with another detector acronym, like TPCTOF. See the examples
ITSReco
vsnumberOfDnsConnections
in the naming conventions.Other detectors are not exceptions, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So
TPCPos
is definitely better thanTPCpos
butTpcPos
is even better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @vkucera,
we prefer not to change the capitalisation of the
v
because for the other detectors used in the Q-vector calculation this is the convention. So it would create troubles and differences.Please @MaximVirta keep the
v
not capital and be consistent with the rest of the Q-vector framework.This PR, as discussed with @ddobrigk, is intended to fix a renaming issue and not to change the convention adopted by us.