Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWGUD: Task to count UPC events in ITSROF #7214

Merged
merged 10 commits into from
Aug 9, 2024
Merged

PWGUD: Task to count UPC events in ITSROF #7214

merged 10 commits into from
Aug 9, 2024

Conversation

rolavick
Copy link
Collaborator

@rolavick rolavick commented Aug 7, 2024

the title says it all

@alibuild alibuild mentioned this pull request Aug 7, 2024
Merged
@rolavick
Merge pull request #34 from alibuild/alibot-cleanup-7214
691dc06 
Please consider the following formatting changes to AliceO2Group#7214
@rolavick rolavick marked this pull request as ready for review August 7, 2024 19:55
@rolavick rolavick enabled auto-merge (squash) August 7, 2024 19:56
alibuild
alibuild previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @rolavick.

@alibuild
Copy link
Collaborator

alibuild commented Aug 7, 2024

Error while checking build/O2Physics/o2 for 691dc06 at 2024-08-08 00:20:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Aug 8, 2024

Error while checking build/O2Physics/o2 for 1bd0514 at 2024-08-08 08:29:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Aug 8, 2024

Error while checking build/O2Physics/o2 for 37713cd at 2024-08-08 12:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7214-slc7_x86-64/0/PWGUD/Tasks/upcEventITSROFcounter.cxx:68:16: error: unused variable 'orbitBC' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@rolavick rolavick disabled auto-merge August 9, 2024 10:56
@rolavick rolavick enabled auto-merge (squash) August 9, 2024 10:57
alibuild
alibuild approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @rolavick.

@rolavick rolavick merged commit 7a7d68a into AliceO2Group:master Aug 9, 2024
9 checks passed
@rolavick rolavick deleted the pileupvtx branch August 9, 2024 12:09
Luca610 pushed a commit to Luca610/O2Physics that referenced this pull request Aug 13, 2024
@rolavick @alibuild @Luca610
PWGUD: Task to count UPC events in ITSROF (AliceO2Group#7214)
ffcff32 
* initial setup of the task

* Task finished

* Please consider the following formatting changes

* add libraries

* fix

* delete

* fix

* clean

---------

Co-authored-by: ALICE Action Bot <[email protected]>
joonsukbae pushed a commit to joonsukbae/O2Physics that referenced this pull request Aug 27, 2024
@rolavick @alibuild @joonsukbae
PWGUD: Task to count UPC events in ITSROF (AliceO2Group#7214)
175d9ec 
* initial setup of the task

* Task finished

* Please consider the following formatting changes

* add libraries

* fix

* delete

* fix

* clean

---------

Co-authored-by: ALICE Action Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alibuild alibuild alibuild approved these changes

@pbuehler pbuehler Awaiting requested review from pbuehler pbuehler is a code owner

@abylinkin abylinkin Awaiting requested review from abylinkin abylinkin is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolavick @alibuild