introducing gamma-jet tree producer task #7367

fjonasALICE · 2024-08-20T14:04:23Z

addition of new workflow which allows to store a tree containing photons and jets, including isolation information for the jet. Ideal derived data to perform any gamma-jet analysis

PWGJE/DataModel/GammaJetAnalysisTree.h

PWGJE/Tasks/gammajettreeproducer.cxx

nzardosh · 2024-08-20T14:20:00Z

PWGJE/Tasks/gammajettreeproducer.cxx

+  // an integer instead
+  Filter clusterDefinitionSelection = (o2::aod::jcluster::definition == mClusterDefinition);
+  // Process clusters
+  void processClusters(soa::Join<JetCollisions, aod::BkgChargedRhos, aod::JCollisionBCs>::iterator const& collision, aod::JBCs const&, selectedClusters const& clusters, JetTracks const& tracks)


you can remove JBCs once you remove zorro

Hi Florian this is not resolved yet

removed JBCs

PWGJE/Tasks/gammajettreeproducer.cxx

Please consider the following formatting changes to AliceO2Group#7367

fjonasALICE · 2024-09-04T15:25:03Z

Hi @nzardosh I implemented almost all your comments, except for the filter for jet pt, which i will implement later (but i think it is not crucial)

nzardosh · 2024-09-05T12:14:53Z

PWGJE/Tasks/gammajettreeproducer.cxx

+  // an integer instead
+  Filter clusterDefinitionSelection = (o2::aod::jcluster::definition == mClusterDefinition);
+  // Process clusters
+  void processClusters(soa::Join<JetCollisions, aod::BkgChargedRhos, aod::JCollisionBCs>::iterator const& collision, aod::JBCs const&, selectedClusters const& clusters, JetTracks const& tracks)


Hi Florian this is not resolved yet

nzardosh · 2024-09-05T12:17:05Z

PWGJE/Tasks/CMakeLists.txt

+    o2physics_add_dpl_workflow(gamma-jet-tree-producer
+                        SOURCES gammajettreeproducer.cxx
+                        PUBLIC_LINK_LIBRARIES O2::Framework O2::EMCALBase O2::EMCALCalib O2Physics::PWGJECore O2Physics::AnalysisCore
+                        O2Physics::EventFilteringUtils


I think this is not needed anymore since you dont interface with zorro

both removed

nzardosh · 2024-09-05T12:20:07Z

PWGJE/Tasks/gammajettreeproducer.cxx

+using namespace o2;
+using namespace o2::framework;
+using namespace o2::framework::expressions;
+using bcEvSelIt = o2::soa::Join<o2::aod::BCs, o2::aod::BcSels>::iterator;


this isnt used anywhere

nzardosh · 2024-09-05T12:22:21Z

PWGJE/Tasks/gammajettreeproducer.cxx

+  Configurable<float> isoR{"isoR", 0.4, "isolation cone radius"};
+
+  // cluster cuts
+  Configurable<int> mClusterDefinition{"clusterDefinition", 10, "cluster definition to be selected, e.g. 10=kV3Default"};


might be more useful to take this input as a string so that if the definitions change you'e still safe. you can see how in the jetfinder

prefer to keep consistent with other tasks for now, will change eventually

nzardosh · 2024-09-05T12:23:21Z

PWGJE/Tasks/gammajettreeproducer.cxx

+
+    double dPhi = TVector2::Phi_0_2pi(phi1) - TVector2::Phi_0_2pi(phi2);
+    if (abs(dPhi) > M_PI) {
+      dPhi = 2 * M_PI - abs(dPhi);


use the deltaR function from jetutilities. you can give it to objects and it gives you back the DeltaR

replaced with deltaR function. I did some additional fixes to deltaR function in jetutilities that should improve convenience and safety

nzardosh · 2024-09-05T12:26:08Z

PWGJE/Tasks/gammajettreeproducer.cxx

+    if (collision.posZ() > mVertexCut) {
+      return false;
+    }
+    if (!jetderiveddatautilities::selectCollision(collision, eventSelection) || !jetderiveddatautilities::selectTrigger(collision, triggerMaskBits)) {


in the jet finder i dont think we apply collision selection in parallel to emcal selections. Check that this is what you want

will leave for now but will clarify with Nicolas Strangmann for a future update

nzardosh · 2024-09-05T12:31:11Z

PWGJE/Tasks/gammajettreeproducer.cxx

+      //   dEta = 0;
+      // }
+
+      gammasTable(collisionMapping[collision.globalIndex()], cluster.energy(), cluster.eta(), cluster.phi(), cluster.m02(), cluster.m20(), cluster.nCells(), cluster.time(), cluster.isExotic(), cluster.distanceToBadChannel(), cluster.nlm(), isoraw, perpconerho, dPhi, dEta, p);


here I am not sure you can get the table index via collisionMapping[collision.globalIndex()]
You should use the find function and then get the second element of the pair returned with a protection that it doesnt reach the end.

For here however you can actually just use eventsTable.lastIndex() since it should be fine

fixed and changed to unordered map to improve performance

nzardosh · 2024-09-05T12:31:25Z

PWGJE/Tasks/gammajettreeproducer.cxx

+
+  Filter jetCuts = aod::jet::pt > jetPtMin&& aod::jet::r == nround(jetR.node() * 100.0f);
+  // Process charged jets
+  void processChargedJets(soa::Join<JetCollisions, aod::BkgChargedRhos, aod::JCollisionBCs>::iterator const& collision, aod::JBCs const&, soa::Filtered<soa::Join<aod::ChargedJets, aod::ChargedJetConstituents>> const& chargedJets, JetTracks const&)


remove JBCs

nzardosh · 2024-09-05T12:34:51Z

PWGJE/Tasks/gammajettreeproducer.cxx

+        nconst++;
+      }
+
+      chargedJetsTable(collisionMapping[collision.globalIndex()], jet.pt(), jet.eta(), jet.phi(), jet.energy(), jet.mass(), jet.area(), nconst);


here get the pair according to the comment above. If you need an example you can look in the derived data write. I'm surprised it compiles actually.

nzardosh · 2024-09-05T12:35:31Z

PWGJE/Tasks/gammajettreeproducer.cxx

+WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
+{
+  WorkflowSpec workflow{
+    adaptAnalysisTask<GammaJetTreeProducer>(cfgc, TaskName{"gamma-jet-tree-producer"}, SetDefaultProcesses{{{"processClearMaps", true}, {"processClusters", true}, {"processChargedJets", true}}})};


instead of adding the process functions as true here you can instead remove it here and add them as true in the process switches

Please consider the following formatting changes to AliceO2Group#7367

* introducing gamma-jet tree producer task * fix missing new line in gj tree producer * update of software triggers for GJ tree * delection of obsolete table subscription, map improvements * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <[email protected]>

fjonasALICE requested review from alibuild, maoyx, nzardosh, ddobrigk and mfasDa as code owners August 20, 2024 14:04

fjonasALICE force-pushed the master branch from 552fa71 to e409ca9 Compare August 20, 2024 14:11

nzardosh reviewed Aug 20, 2024

View reviewed changes

fjonasALICE added 3 commits September 3, 2024 11:27

introducing gamma-jet tree producer task

044bee9

fix missing new line in gj tree producer

97680ef

update of software triggers for GJ tree

c5c45e7

fjonasALICE force-pushed the master branch from e409ca9 to c5c45e7 Compare September 4, 2024 15:14

alibuild mentioned this pull request Sep 4, 2024

Please consider the following formatting changes to #7367 fjonasALICE/O2Physics#1

Merged

fjonasALICE added a commit to fjonasALICE/O2Physics that referenced this pull request Sep 4, 2024

Merge pull request #1 from alibuild/alibot-cleanup-7367

19ccb54

Please consider the following formatting changes to AliceO2Group#7367

nzardosh reviewed Sep 5, 2024

View reviewed changes

delection of obsolete table subscription, map improvements

23d6db8

fjonasALICE force-pushed the master branch from 19ccb54 to 23d6db8 Compare September 6, 2024 12:12

Please consider the following formatting changes

5c514fd

alibuild mentioned this pull request Sep 6, 2024

Please consider the following formatting changes to #7367 fjonasALICE/O2Physics#2

Merged

Merge pull request #2 from alibuild/alibot-cleanup-7367

86ccf2a

Please consider the following formatting changes to AliceO2Group#7367

nzardosh self-requested a review September 9, 2024 12:22

nzardosh approved these changes Sep 9, 2024

View reviewed changes

nzardosh merged commit 59a7b7a into AliceO2Group:master Sep 9, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introducing gamma-jet tree producer task #7367

introducing gamma-jet tree producer task #7367

fjonasALICE commented Aug 20, 2024

nzardosh Aug 20, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

fjonasALICE commented Sep 4, 2024

nzardosh Sep 5, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

nzardosh Sep 5, 2024

fjonasALICE Sep 6, 2024

introducing gamma-jet tree producer task #7367

introducing gamma-jet tree producer task #7367

Conversation

fjonasALICE commented Aug 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fjonasALICE commented Sep 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment