Protect against and diagnose OrbitReset issues #7622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the caching of the start-of-run and end-of-run timestamps in addition to the orbit-reset timestamp. It also validates that the calculated timestamp is within the run duration before adding it to the timestamp table. This ensures that only valid timestamps are used, improving the reliability of the data.
mpuccio
requested review from
alibuild,
jgrosseo,
iarsene,
ktf,
ddobrigk and
a team
as code owners
The changes introduce a new configurable option `fatalOnInvalidTimestamp` that allows the user to control the behavior when the timestamp information is not available in the CCDB. When set to `true`, the task will generate a fatal error, otherwise it will just log a warning. This gives the user more control over how to handle invalid timestamps. Additionally, the commit clarifies the meaning of the SOR/EOR timestamps, indicating that they can represent the start/end of the run, or the start/end of the sub-timeframe, depending on the run type.
|
Hi @chiarazampolli : I would still keep the same behaviour to avoid issues with the analysers, so I put a configurable that regulates the "fatalisation" on invalid BCs. As Ruben saw in the AO2Ds for the other run, we might have a few spurious BCs, but if they are not referred by other tables there is no point in issuing a |
jgrosseo
approved these changes
Sep 10, 2024
fchinu
pushed a commit
to fchinu/O2Physics
that referenced
this pull request
Sep 18, 2024
* Protect against and diagnose OrbitReset issues This change adds the caching of the start-of-run and end-of-run timestamps in addition to the orbit-reset timestamp. It also validates that the calculated timestamp is within the run duration before adding it to the timestamp table. This ensures that only valid timestamps are used, improving the reliability of the data. * Add configurable option to make invalid timestamps fatal The changes introduce a new configurable option `fatalOnInvalidTimestamp` that allows the user to control the behavior when the timestamp information is not available in the CCDB. When set to `true`, the task will generate a fatal error, otherwise it will just log a warning. This gives the user more control over how to handle invalid timestamps. Additionally, the commit clarifies the meaning of the SOR/EOR timestamps, indicating that they can represent the start/end of the run, or the start/end of the sub-timeframe, depending on the run type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the caching of the start-of-run and end-of-run timestamps
in addition to the orbit-reset timestamp. It also validates that the
calculated timestamp is within the run duration before adding it to the
timestamp table. This ensures that only valid timestamps are used,
improving the reliability of the data.