Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGHF: fix L(1520) PDG code. #7886

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Conversation

mfaggin
Copy link
Collaborator

@mfaggin mfaggin commented Oct 4, 2024

Fixing Lambda(1520) PDG code in candidateCreator3Prong.cxx, aligning it to the expected value, as done in O2DPG here: PR #1673.

Tested on 1 file of HF_LHC24g5_All MC production (see bin centered at 3 below):

image

@fgrosa fgrosa enabled auto-merge (squash) October 4, 2024 15:59
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfaggin @fgrosa , I think this requires a thorough cross check between the MC numbering scheme and the ROOT numbering scheme, because these two should be identical and if they are not, it can be a big problem.

The code 3124 corresponds to the PDG numbering scheme used in the particle table of TDatabasePDG in ROOT, from where we get the particle properties.

See https://root.cern/doc/master/TPDGCode_8h.html
and grep 1520 $ROOTSYS/etc/pdg_table.txt:

  522 Lambda(1520)0      3124  1 100 Baryon      0 1.519000e+00 1.600000e-02 -100 -1 -100 -1   -1  12
  523 Lambda(1520)_bar  -3124     522     0

If particle.pdgCode() returns the MC code instead of the ROOT one, we have a problem.

@fgrosa
Copy link
Collaborator

fgrosa commented Oct 4, 2024

Hi @vkucera indeed the pdg code for the L(1520) is an issue if one uses TDatabasePDG, because it was modified in pythia but not in ROOT (see the pdg numbering scheme from 2014 was already updated https://pdg.lbl.gov/2014/reviews/rpp2014-rev-monte-carlo-numbering.pdf). I think it would be worth to open an issue / PR in ROOT, what do you think?

@vkucera
Copy link
Collaborator

vkucera commented Oct 4, 2024

Hi @vkucera indeed the pdg code for the L(1520) is an issue if one uses TDatabasePDG, because it was modified in pythia but not in ROOT. I think it would be worth to open an issue / PR in ROOT, what do you think?

I agree. Can you link the change in PYTHIA here?

@fgrosa fgrosa merged commit f9b14df into AliceO2Group:master Oct 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants