PWGHF: Add Selector Variables for Lc->PKPi Selector task #7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phymanshu
commented
Oct 7, 2024
phymanshu
commented
- Adding selector variables in Lc->PKPi selector similar to Xic->PKPi
Add More Variables in the LcToPKPi selector
Add More Selector Variables
phymanshu
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
hahassan7,
jpxrk and
apalasciano
as code owners
mfaggin
requested changes
Oct 7, 2024
PWGHF/Core/SelectorCuts.h
Outdated
Comment on lines
482
to
492
| // default values for the cuts m, ptP, ptK, ptPi, chi2PCA, dL, cosp, dLXY, NdLXY, ct, ImpParXY mass(Kpi) | ||
| constexpr double cuts[nBinsPt][nCutVars] = {{0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 0 < pT < 1 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 1 < pT < 2 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 2 < pT < 3 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 3 < pT < 4 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 4 < pT < 5 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 5 < pT < 6 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 6 < pT < 8 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 8 < pT < 12 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}, /* 12 < pT < 24 */ | ||
| {0.4, 0.4, 0.4, 0.4, 0., 0.005, 0., 0.005, 1., 100., 0.5, -1.}}; /* 24 < pT < 36 */ |
There was a problem hiding this comment.
thanks @phymanshu , ok for me to add such cuts if needed, however I'd use default values such that no new selections are applied (i.e.: I'd use 0 as default for decLengthXY and normDecLXY, and 1e+10 for ct and impParXY)
Please consider the following formatting changes to AliceO2Group#7907
mfaggin
requested changes
Oct 7, 2024
Comment on lines
214
to
217
| // candidate ct | ||
| if (hfHelper.ctXic(candidate) > cuts->get(pTBin, "ct")) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
do you really need a cut on hfHelper.ctXic(candidate)? If yes, I'd anyway remove it from the default selections for Lambdac, and eventually add a specific Configurable in the selector. I do not like the idea to have a Xic-related cut in the code of Lambdac
mfaggin
reviewed
Oct 7, 2024
mfaggin
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.