PWGCF: fixed QA flags #7962
PWGCF: fixed QA flags #7962
Conversation
abilandz
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
There was a problem hiding this comment.
Please, check that you are not rolling back changes done for standardization and converting compiler warnings to errors
I pointed them out for you to check them
Also
- there was an issue with the
absfunction which started to return anintas it should. But this caused a lot of unexpected behaviors because people had extensively used it. Check that you are usingstd::absinstead - Prefix your PR and commit titles with
PWGCF:
| @@ -189,7 +189,7 @@ struct MultiparticleCorrelationsAB // this name is used in lower-case format to | |||
| // ------------------------------------------- | |||
|
|
|||
| // C) Process only simulated data: | |||
| void processSim(CollisionSim const& /*collision*/, aod::BCs const&, TracksSim const& /*tracks*/) | |||
| void processSim(CollisionSim const& collision, aod::BCs const&, TracksSim const& tracks) | |||
There was a problem hiding this comment.
Please, don't remove the commented out collisions and tracks
We are in the process of converting all warnings to errors and this is a not used variable warning
They were changed in the past directly on gitHub so probably you are still having locally an old version
There was a problem hiding this comment.
This was rolled back by mistake - I pushed a new commit, which brings this back!
| @@ -216,7 +216,7 @@ struct MultiparticleCorrelationsAB // this name is used in lower-case format to | |||
| // ------------------------------------------- | |||
|
|
|||
| // F) Process only converted simulated Run 2 data: | |||
| void processSim_Run2(CollisionSim const& /*collision*/) // TBI 20240517 extend this subscription eventually | |||
| void processSim_Run2(CollisionSim const& collision) // TBI 20240517 extend this subscription eventually | |||
| @@ -234,7 +234,7 @@ struct MultiparticleCorrelationsAB // this name is used in lower-case format to | |||
| // ------------------------------------------- | |||
|
|
|||
| // H) Process both converted reconstructed and corresponding MC truth simulated Run 1 data; | |||
| void processRecSim_Run1(CollisionRecSim_Run1 const& /*collision*/, aod::BCs const&, TracksRecSim const& /*tracks*/, aod::McParticles const&, aod::McCollisions const&) | |||
| void processRecSim_Run1(CollisionRecSim_Run1 const& collision, aod::BCs const&, TracksRecSim const& tracks, aod::McParticles const&, aod::McCollisions const&) | |||
| @@ -2080,7 +2105,7 @@ void BookParticleCutsHistograms() | |||
| if (pc.fUseParticleCuts[ePtDependentDCAxyParameterization]) { | |||
| pc.fPtDependentDCAxyFormula = new TFormula("fPtDependentDCAxyFormula", pc.fsParticleCuts[ePtDependentDCAxyParameterization].Data()); | |||
| // As a quick insanity check, try immediately to evaluate something from this formula: | |||
| if (std::isnan(pc.fPtDependentDCAxyFormula->Eval(1.44))) { | |||
| if (isnan(pc.fPtDependentDCAxyFormula->Eval(1.44))) { | |||
There was a problem hiding this comment.
Any reason for removing the std:: on isnan?
I think this was introduced directly on gitHub to standardize the code and perhaps you are still using an old local version. Please, check it
There was a problem hiding this comment.
I didn't pull these changes in my class done directly on GitHub, that's the only reason. In the latest commit, I switched back to std::
| // *) std::isnan() check (remember that 'nan' is 0./0., inf-inf, etc. However 'inf' itself is NOT a 'nan', therefore std::isnan(1./0.) is false, std::isnan(0./0.) is true, etc.): | ||
| if (std::isnan(track.phi()) || std::isnan(track.pt()) || std::isnan(track.eta())) { | ||
| // *) isnan() check (remember that 'nan' is 0./0., inf-inf, etc. However 'inf' itself is NOT a 'nan', therefore isnan(1./0.) is false, isnan(0./0.) is true, etc.): | ||
| if (isnan(track.phi()) || isnan(track.pt()) || isnan(track.eta())) { |
|
Thanks! |
No description provided.