PWGCF: flow-task: fix mistakes and add option to consume less memory #7971
+114
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luzhiyongg
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
victor-gonzalez
requested changes
Oct 12, 2024
PWGCF/Flow/Tasks/FlowTask.cxx
Outdated
Comment on lines
568
to
582
| switch (cfgFilterFlag) { | ||
| case 0: | ||
| return track.isGlobalTrack(); | ||
| case 1: | ||
| return (track.isGlobalTrackSDD() == (uint8_t) true); | ||
| case 2: | ||
| return (track.isGlobalTrackWoTPCCluster() && track.tpcNClsFound() >= cfgCutTPCclu); | ||
| case 3: | ||
| return (track.isGlobalTrackWoPtEta() && (abs(track.eta()) < cfgCutEta) && (track.pt() > cfgCutPtMin) && (track.pt() < cfgCutPtMax)); | ||
| case 4: | ||
| return (track.isGlobalTrackWoDCA() && abs(track.dcaZ()) <= cfgCutDCAz && abs(track.dcaXY()) <= cfgCutDCAxy * pow(track.pt(), -1.1)); | ||
| case 5: | ||
| return (track.isGlobalTrackWoDCATPCCluster() && abs(track.dcaZ()) <= cfgCutDCAz && abs(track.dcaXY()) <= cfgCutDCAxy * pow(track.pt(), -1.1) && track.tpcNClsFound() >= cfgCutTPCclu); | ||
| default: | ||
| return false; |
There was a problem hiding this comment.
Please, don't use abs. It turned out that now it is behaving as it should have, i.e. return an int
Use instead std::fabs
|
Hi @victor-gonzalez , thank you for your remind for the abs! I have fixed this. I am using o2 inline node function nabs(). Is it corrected? |
victor-gonzalez
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.