Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWGUD Table Producers modified to include the UPC Reco flag in collisions #7975

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

PWGUD Table Producers modified to include the UPC Reco flag in collisions #7975

wants to merge 45 commits into from
+148 −26

Conversation

abylinkin
Copy link
Collaborator

No description provided.

@alibuild alibuild mentioned this pull request Oct 12, 2024
Merged
@abylinkin
Merge pull request #71 from alibuild/alibot-cleanup-7975
351608d 
Please consider the following formatting changes to AliceO2Group#7975
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 351608d at 2024-10-12 23:50:

## sw/BUILD/O2Physics-latest/log
/sw/slc7_x86-64/O2/daily-20241012-0200-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc7_x86-64/O2/daily-20241012-0200-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<long unsigned int, int, float, float, float, short unsigned int, short unsigned int, signed char, float>(const std::array<const char*, 9>&)::<lambda(unsigned int, o2::framework::BuilderMaker<long unsigned int>::FillType, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<short unsigned int>::FillType, o2::framework::BuilderMaker<short unsigned int>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<float>::FillType)>::*)(unsigned int, long unsigned int, int, float, float, float, short unsigned int, short unsigned int, signed char, float) const>::type {aka std::function<void(unsigned int, long unsigned int, int, float, float, float, short unsigned int, short unsigned int, signed char, float)>}) (int, const long int&, const long unsigned int&, const int&, const float&, const float&, const float&, const float&, const short unsigned int&, const signed char&, const float&)'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:920:86: error: 'using o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::iterator = o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowView<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >' {aka 'struct o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowViewBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >'} has no member named 'flags'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:985:86: error: 'using o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::iterator = o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowView<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >' {aka 'struct o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowViewBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >'} has no member named 'flags'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1162:80: error: 'using o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId> >::iterator = struct o2::soa::Table<o2::framework::OriginEnc{1313427274}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId>::RowViewBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId> >, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId> >' {aka 'struct o2::soa::Table<o2::framework::OriginEnc{1313427274}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId>::RowViewBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId> >, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId> >'} has no member named 'flags'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1382:86: error: 'using o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::iterator = o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowView<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >' {aka 'struct o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowViewBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >'} has no member named 'flags'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1577:86: error: 'using o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::iterator = o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowView<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >' {aka 'struct o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>::RowViewBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask> >'} has no member named 'flags'
ninja: build stopped: subcommand failed.

Full log here.

@rolavick
Fix error in UPCCandProducer when building O2Physics
e92b048 
I assume the error is due to BCFlags table not to be joined with BC table
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for e92b048 at 2024-10-13 18:22:

## sw/BUILD/O2Physics-latest/log
/sw/slc7_x86-64/O2/daily-20241013-0200-local1/include/Framework/AnalysisHelpers.h:48:33: error: static assertion failed: Argument number mismatch
/sw/slc7_x86-64/O2/daily-20241013-0200-local1/include/Framework/AnalysisHelpers.h:50:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<long unsigned int, int, float, float, float, short unsigned int, short unsigned int, signed char, float>(const std::array<const char*, 9>&)::<lambda(unsigned int, o2::framework::BuilderMaker<long unsigned int>::FillType, o2::framework::BuilderMaker<int>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<float>::FillType, o2::framework::BuilderMaker<short unsigned int>::FillType, o2::framework::BuilderMaker<short unsigned int>::FillType, o2::framework::BuilderMaker<signed char>::FillType, o2::framework::BuilderMaker<float>::FillType)>::*)(unsigned int, long unsigned int, int, float, float, float, short unsigned int, short unsigned int, signed char, float) const>::type {aka std::function<void(unsigned int, long unsigned int, int, float, float, float, short unsigned int, short unsigned int, signed char, float)>}) (int, const long int&, const long unsigned int&, const int&, const float&, const float&, const float&, const float&, const short unsigned int&, const signed char&, const float&)'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1640:29: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1689:29: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1709:25: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1729:25: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1749:31: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 33e487b at 2024-10-13 20:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1640:29: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1689:29: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1709:25: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1729:25: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1749:31: error: cannot convert 'const o2::aod::BCs' {aka 'const o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Oct 14, 2024
Merged
@alibuild alibuild mentioned this pull request Oct 14, 2024
Closed
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for f681483 at 2024-10-14 10:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1640:29: error: cannot convert 'const UpcCandProducer::BCsWithBcSels' {aka 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1689:29: error: cannot convert 'const UpcCandProducer::BCsWithBcSels' {aka 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1709:25: error: cannot convert 'const UpcCandProducer::BCsWithBcSels' {aka 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1729:25: error: cannot convert 'const UpcCandProducer::BCsWithBcSels' {aka 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1749:31: error: cannot convert 'const UpcCandProducer::BCsWithBcSels' {aka 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::evsel::Alias, o2::aod::evsel::Selection, o2::aod::evsel::FoundFT0Id, o2::aod::evsel::FoundFV0Id, o2::aod::evsel::FoundFDDId, o2::aod::evsel::FoundZDCId>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >'} to 'const o2::soa::Join<o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::bc::RunNumber, o2::aod::bc::GlobalBC, o2::aod::bc::TriggerMask, o2::aod::bc::InputMask>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::bc::Flags> >&'
ninja: build stopped: subcommand failed.

Full log here.

rolavick and others added 2 commits October 14, 2024 11:08
@rolavick
Update UPCCandidateProducer.cxx
8ffb917 
All BCs should have now have the same table definitions
@abylinkin
Update SGCandProducer.cxx
b9a2703
@alibuild alibuild mentioned this pull request Oct 14, 2024
Merged
@alibuild alibuild mentioned this pull request Oct 14, 2024
Merged
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for b831ae0 at 2024-10-14 14:16:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/SGCandProducer.cxx:219:19: error: 'Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGCandProducer.cxx:275:19: error: 'Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:421:23: error: 'Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:621:25: error: 'Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:694:25: error: 'Vertex' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@rolavick
Update DGBCCandProducer.cxx
1fa5828 
fix of Vertex::UPCMode
@rolavick
Update DGCandProducer.cxx
628dd34 
fix of Vertex::UPCMode
@rolavick
Update SGCandProducer.cxx
f9417a4 
fix of Vertex::UPCMode
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for f9417a4 at 2024-10-14 16:02:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGCandProducer.cxx:275:28: error: 'o2::aod::Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/SGCandProducer.cxx:219:28: error: 'o2::aod::Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:421:32: error: 'o2::aod::Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:621:34: error: 'o2::aod::Vertex' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:694:34: error: 'o2::aod::Vertex' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@rolavick
Update UPCCandidateProducer.cxx
6fc1b27 
TODO added to not forget the implementation of collision flag association via bc table is not fully correct.

bcs.iteratorAt(0) takes only first BC in a timeframe, and in an analysis task data should be processed TF-by-TF (if I'm not mistaken again), so it should be a corresponding BCId for each collision.
UPCCandidateProducer matches tracks by time (BC) independently of reconstructed vertices, so additional checks should be added at some point to determine settings for a given ITSROF based e.g. on track BCs.
@rolavick
Update DGBCCandProducer.cxx
62e6cbb 
fix
@rolavick
Update DGCandProducer.cxx
2d57f3b 
fix
@rolavick
Update SGCandProducer.cxx
3518cd8 
fix
@rolavick
Update DGBCCandProducer.cxx
2147ce2 
fix
@rolavick
Update DGCandProducer.cxx
59cb78f 
fix
@rolavick
Update DGCandProducer.cxx
59ab738 
fix
@rolavick
Update DGBCCandProducer.cxx
a1da96e
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for a1da96e at 2024-10-14 19:08:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/SGCandProducer.cxx:219:28: error: 'o2::aod::dataformats' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGCandProducer.cxx:275:28: error: 'o2::aod::dataformats' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:421:32: error: 'o2::aod::dataformats' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:621:34: error: 'o2::aod::dataformats' has not been declared
/sw/SOURCES/O2Physics/7975-slc7_x86-64/0/PWGUD/TableProducer/DGBCCandProducer.cxx:694:34: error: 'o2::aod::dataformats' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@rolavick rolavick enabled auto-merge (squash) October 14, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler pbuehler is a code owner

@rolavick rolavick Awaiting requested review from rolavick rolavick is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abylinkin @alibuild @rolavick