[PWGJE] Adjusted logic for TC histogram filling #9006
Closed
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyungjun-lee
requested review from
alibuild,
maoyx,
nzardosh,
fjonasALICE,
mfasDa and
mhemmer-cern
as code owners
github-actions
bot
changed the title
|
Thanks for the PR to save memory. Please fix the mega linter issues since they seem straightforward and then I can approve it :) |
|
I'm sorry for late check this request. I'll request again after adding some modification of logic for TC histogram filling. thanks to comment me, Nima. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TC histogram was creating all histograms related to xy, z, and xyz regardless of the fillIPxy, fillIPz, and fillIPxyz switches.
This could lead to memory waste, so I modified the switch conditions to address this issue.