[PWGCF] Change output structure and implement centrality dependence #9045
+239
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please consider the following formatting changes to AliceO2Group#8879
Please consider the following formatting changes to AliceO2Group#8879
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#9045
| void init(InitContext const&) | ||
| { | ||
| // define axes you want to use | ||
| const AxisSpec axisCounter{4, 0, +2, ""}; |
There was a problem hiding this comment.
I would suggest starting the x axis in -0.5 and run it up to the number of decided bins plus 0.5
Then use an enum to define named constants for each case wanted wanted to be considered and use that named constants to fill the histogram
Also the different bins can also have its own name if so is decided
Comment on lines
46
to
47
| // Configurable<int> cfgCentralityEstimator{"cfgCentralityEstimator", 0, "Choice of centrality estimator"};//0 for FTOC, 1 for FTOA, 2 for FTOM, 3 for FVOA. //To be included at a later stage | ||
| // Configurable<bool> cfgProcessRun2{"cfgProcessRun2", false, "Analyse Run 2 converted data"};//To be included at a later stage |
There was a problem hiding this comment.
Please, for the next iteration don't leave code commented
| void processRun3(soa::Filtered<soa::Join<aod::Collisions, aod::EvSels, CentralitiesRun3>>::iterator const& collision, BCsRun3 const&, aod::Zdcs const&) | ||
| { | ||
| if (!collision.sel8()) { | ||
| histos.fill(HIST("eventCounter"), 0.25); |
There was a problem hiding this comment.
See my previous comment
Please consider the following formatting changes to AliceO2Group#9045
Please consider the following formatting changes to AliceO2Group#9045
omassen
requested review from
alibuild,
saganatt,
zchochul,
lgraczykCern,
prchakra,
lauraser,
ariedel-cern,
otonvd and
shouqiye
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the structure how the histograms are stored in the output file, using folders for the A- and C-side of the ZDC. Also implemented a more realistic way of filling the histograms for the different sectors on the two sides. Finally a maximum centrality limit and centrality dependence was implemented for most histograms.