Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWGUD] Added few more TPC N Sigmas #9108

Merged
merged 17 commits into from
Dec 23, 2024

Conversation

ananthapadmanabhan18
Copy link
Contributor

Could anyone tell me how to remove the error caused by O2 linter? I will fix it and update it in PR

@github-actions github-actions bot added the pwgud label Dec 22, 2024
@github-actions github-actions bot changed the title Added few more TPC N Sigmas [PWGUD] Added few more TPC N Sigmas Dec 22, 2024
@rolavick rolavick enabled auto-merge (squash) December 23, 2024 14:26
Copy link
Collaborator

@rolavick rolavick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the remaining O2 linter you might want to consult with @vkucera . Currently, I do not see it as an obstacle for the merge, so I approve

@rolavick rolavick merged commit 916dd1d into AliceO2Group:master Dec 23, 2024
12 of 13 checks passed
@ananthapadmanabhan18
Copy link
Contributor Author

Sure, I will consult with him. Thanks for letting me know!

@vkucera
Copy link
Collaborator

vkucera commented Dec 23, 2024

Hi @ananthapadmanabhan18 , how can I help with the O2 linter errors?

@ananthapadmanabhan18
Copy link
Contributor Author

Hello @vkucera . 90% of the errors in the O2 linter is due to the following error shown in the picture:

image

The problem is...for the data types say PtEtaPhiVector, which is the types in standard C++ or O2 replaces these ?

( I have checked the lines in which the error is showing and found out one of them was PtEtaPhiVector. There are many others like this only )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants