Skip to content

Commit

Permalink
[OGUI-1421] Sort display of detectors alphabetically & patch release (#…
Browse files Browse the repository at this point in the history
…2156)

* Display list of detectors alphabetically
* Bump patch version
  • Loading branch information
graduta authored Oct 6, 2023
1 parent 111cd8a commit 0da255a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Control/lib/adapters/EnvironmentInfoAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class EnvironmentInfoAdapter {
epn: EnvironmentInfoAdapter._getOdcCounters(integratedServicesData.odc ?? {}),
},
tasks: [],
includedDetectors,
includedDetectors: includedDetectors.sort(),
defaults: EnvironmentInfoAdapter._filterOutDetectorsVariables(defaults, includedDetectors, detectorsAll),
vars: EnvironmentInfoAdapter._filterOutDetectorsVariables(vars, includedDetectors, detectorsAll),
userVars: EnvironmentInfoAdapter._filterOutDetectorsVariables(userVars, includedDetectors, detectorsAll),
Expand Down
4 changes: 2 additions & 2 deletions Control/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Control/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@aliceo2/control",
"version": "1.64.0",
"version": "1.64.1",
"description": "ALICE O2 Control GUI",
"author": "George Raduta",
"contributors": [
Expand Down
4 changes: 2 additions & 2 deletions Control/public/environment/environmentsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const requestsTable = (model, requests) =>
requests.map(item => h('tr', {style: {background: item.failed ? 'rgba(214, 38, 49, 0.2)' : ''}}, [
h('td', {style: 'text-align: center;'}, item.envId || '-'),
h('td', {style: 'text-align: center;'},
item.detectors && item.detectors.length > 0 ? item.detectors.join(' ') : '-'
item.detectors && item.detectors.length > 0 ? item.detectors.sort().join(' ') : '-'
),
h('td', {style: 'text-align: center;'}, item.workflow.substring(
item.workflow.lastIndexOf('/') + 1, item.workflow.indexOf('@')
Expand Down Expand Up @@ -160,7 +160,7 @@ const environmentsTable = (model, list) => {
),
h('td', {style: 'text-align: center;'}, [
item.includedDetectors && item.includedDetectors.length > 0 ?
item.includedDetectors.map((detector) => `${detector} `)
item.includedDetectors.sort().map((detector) => `${detector} `)
: '-'
]),
h('td', {style: 'text-align: center;'}, item.userVars.run_type ? item.userVars.run_type : '-'),
Expand Down

0 comments on commit 0da255a

Please sign in to comment.