Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OGUI-1579] InfoLogger setup documentation updated, npm run simul fixed. #2666

Conversation

Houwie7000
Copy link
Collaborator

@Houwie7000 Houwie7000 commented Nov 19, 2024

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • N/A issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • N/A FLP integration tests were ran successful

README.MD updated to describe the setup of a development MariaDB database using Docker.
Updated npm run simul to call a proxy file.

Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, great idea for adding instructions for setting up docker image for the Database of InfoLogger in development mode.

I have seen you added adminer which is deprecated (https://hub.docker.com/_/adminer/ ). What do you think about using the official phpadmin one instead? https://hub.docker.com/_/phpmyadmin

@Houwie7000 Houwie7000 requested a review from graduta November 21, 2024 18:07
Copy link
Collaborator Author

@Houwie7000 Houwie7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made the changes.

@graduta graduta merged commit c8a5281 into dev Nov 25, 2024
9 checks passed
@graduta graduta deleted the improvement/Houwie7000/OGUI-1579/infologger-setup-information-improve branch November 25, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants