[OGUI-1578] Added vscode debugging configuration in launch.js #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitignore exception made for .vscode/launch.js. Added --inspect parameter to npm run dev command to enable node debugging from the browser.
graduta
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Hi, Jasper! Thank you for adding a configuration to quickly start a server in dev mode. Please see my comments on some changes that I think need to be done before approving this PR.
One more general comment, please make sure to add a new line at the end of the files when you commit. This is checked by the lint process by also by GitHub if you check the files in your PR changes.(attaching here a small screenshot as well)
…ific path options.
|
I've resolved the feedback, the config now works on *nix like platforms and on Windows. |
graduta
approved these changes
Nov 21, 2024
graduta
deleted the
feature/Houwie7000/OGUI-1578/vs-code-launch-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Added vscode debugging configuration in launch.js
.gitignore exception made for .vscode/launch.js.
Added --inspect parameter to npm run dev command to enable node debugging from the browser.