Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OGUI-1455] PART 1. SQL queries logging. #2675

Merged

Conversation

Houwie7000
Copy link
Contributor

@Houwie7000 Houwie7000 commented Nov 25, 2024

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

Status not set to in review due to part 2 (live logging) getting a separate branch/pr.
When part 2 is up for review it will be updated.

Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Houwie7000 . I added a few comments on how to update the test files and structure so that tests are kept organised and within their scope

@Houwie7000 Houwie7000 requested a review from graduta November 26, 2024 14:24
graduta
graduta previously approved these changes Dec 3, 2024
@graduta graduta merged commit 205a59e into dev Dec 3, 2024
4 checks passed
@graduta graduta deleted the feature/Houwie7000/OGUI-1455/log-query-regex-expressions branch December 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants