Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul project setup #7

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Overhaul project setup #7

wants to merge 5 commits into from

Conversation

zt64
Copy link

@zt64 zt64 commented May 15, 2024

Hi,

I decided to completely redesign the project setup, making greater use of Gradle functionality.

  • Switched to version catalog
  • Enabled on demand configuration for optimal performance
  • Updated gradle to v7.6.2
  • Automatic plugin including, no need to 50x include("pluginA")...
  • Added ktlint and editorconfig

@zf-moth
Copy link

zf-moth commented Jun 30, 2024

Is there some reason to not merge it?

gradle.properties Outdated Show resolved Hide resolved
plugin/build.gradle.kts Show resolved Hide resolved
renderScript = false
shaders = false
buildConfig = true
resValues = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we support compiling layouts/strings?
or am i insane

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, i've never used or seen it used though. I disabled cause there was the com.aliucord.plugins.R class generated and it never gets used I think

@zt64 zt64 requested a review from rushiiMachine July 6, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants