-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Automate colima delete command with confirmation #3061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for attempting to fix the Colima problems! But sorry, could you explain more?
Why do you think that 3 attempts may be insufficient but 4 would be better?
Also, why delete after 3 attempts when the maximum number of attempts is 4?
first two attempts failed with msg="[hostagent] QEMU did not exit in 3m0s, forcibly killing QEMU"
The timeout issue persists for 2 attempts. So, need to check So on 3rd attempt, it will stop, and 4th attempt it will delete.
a fall back method |
Thanks! But do we know why |
Due to Github actions resource contention? lima-vm/lima#2455 (comment) |
I think this is probably fixed by #3097 , so let's close this for now. If we still end up getting flaky tests we could reconsider! |
It didn't. #3097 (comment) |
@@ -99,8 +99,8 @@ jobs: | |||
break | |||
else | |||
echo "Failed to start Colima. Attempt $i/$ATTEMPT_LIMIT." | |||
if [ $i -eq $ATTEMPT_LIMIT ]; then | |||
colima delete | |||
if [ $i -eq $(($ATTEMPT_LIMIT - 1)) ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @tobitege
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it delete after every failed attempt (except the last one), like this?
if [ $i -lt $ATTEMPT_LIMIT ]; then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but if [ $i -lt $ATTEMPT_LIMIT ]; then
it will delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll change that in my PR then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, like this?
Did you mean unlike this?
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Action link
Give a summary of what the PR does, explaining any non-trivial design decisions
Increased ATTEMPT_LIMIT to 4 to check the inference ( QEMU works in 3rd attempt) lima-vm/lima#2455 (comment)
Other references