Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file uploads #6126

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Fix file uploads #6126

merged 9 commits into from
Jan 7, 2025

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Jan 7, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    CHANGELOG: Fixed file upload, especially for large zip files

Give a summary of what the PR does, explaining any non-trivial design decisions

  • We lost this functionality in a couple recent PRs
  • We also were hitting memory errors with large zips, thank you to Claude for fixing

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:73557de-nikolaik   --name openhands-app-73557de   docker.all-hands.dev/all-hands-ai/openhands:73557de

Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops!

@baxitfund
Copy link

Confirmed

@rbren rbren enabled auto-merge (squash) January 7, 2025 18:49
@rbren rbren merged commit 3733c64 into main Jan 7, 2025
17 checks passed
@rbren rbren deleted the rb/fix-upload branch January 7, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants