Provide a clearer error message when settings are missing midsession #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymyers
commented
Jan 8, 2025
raymyers
commented
Jan 8, 2025
|
New error
|
tofarr
reviewed
Jan 8, 2025
raymyers
force-pushed
the
ray/all-956-user-story-2-nobad-llm-key-set
branch
from
f4aa5f2 to
276d96a
Compare
raymyers
force-pushed
the
ray/all-956-user-story-2-nobad-llm-key-set
branch
from
705d678 to
9da0b4b
Compare
raymyers
force-pushed
the
ray/all-956-user-story-2-nobad-llm-key-set
branch
from
9da0b4b to
bca9b38
Compare
AlexCuadron
pushed a commit
to AlexCuadron/OpenHands
that referenced
this pull request
Jan 13, 2025
AlexCuadron
pushed a commit
to AlexCuadron/OpenHands
that referenced
this pull request
Jan 13, 2025
csmith49
pushed a commit
to csmith49/OpenHands
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
The changes in #6101 made
ConnectionRefusedErrorthrown inlisten_socket.pydisplay to the client. One of those scenarios is "Settings not found". This change gives those an optional "msg_id" for the translation and adds a user facing message that makes it more clear what action to take.Another place this could be addressed is in
frontend/src/hooks/query/use-settings.ts, but I'm not sure how to approach that and making these Websocket errors more first-class seemed like a good direction.Link of any specific issues this addresses
ALL-959