Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prompt): move runtime/repo info to user message and disable them in eval #6291

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Jan 15, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR send runtime/repo info as user message to the LLM, and repurpose use_microagent flag to enable_prompt_extensions and disable it by default in evaluation.

Quick eval here on 100 instances from SWE-Bench Verified (w/ 30 max turns) - at least no degradation & slightly better (could due to randomness though)

  • main: 37/100
  • this PR: 39/100

Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:9ee18fd-nikolaik   --name openhands-app-9ee18fd   docker.all-hands.dev/all-hands-ai/openhands:9ee18fd

@xingyaoww xingyaoww marked this pull request as ready for review January 16, 2025 17:21
@xingyaoww
Copy link
Collaborator Author

Quick eval here on 100 instances from SWE-Bench Verified (w/ 30 max turns) - at least no degradation & slightly better (could due to randomness though)
main: 37/100
this PR: 39/100

@xingyaoww xingyaoww requested review from neubig, rbren and mamoodi January 16, 2025 17:25
Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is working as expected!

@xingyaoww xingyaoww enabled auto-merge (squash) January 16, 2025 17:34
@xingyaoww xingyaoww merged commit 0c961bf into main Jan 16, 2025
18 checks passed
@xingyaoww xingyaoww deleted the xw/prompt-mng branch January 16, 2025 17:53
csmith49 pushed a commit to csmith49/OpenHands that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants