Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added temporary Railways TFC compat #2

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Conversation

pietro-lopes
Copy link
Contributor

  • Locked dependency to this exact railways version
  • Cursed Enum Mixin (by gigaherz)

All this stuff can be removed when Steam and Rails add their compat.

- Locked dependency to this exact railways version
- Cursed Enum Mixin (by gigahertz)
build.gradle Show resolved Hide resolved
build.gradle Show resolved Hide resolved
- added Railway Team maven
- using Create "all" version from their maven
- add @mutable to shadowed value
@pietro-lopes pietro-lopes requested a review from screret January 11, 2024 18:27
@screret screret merged commit a045388 into AllTheMods:main Jan 14, 2024
@IThundxr
Copy link

@pietro-lopes could you grab a log of it crashing with the dep on my maven? I'll look into fixing that since people should be depending on the stable jars from the maven (release ones without build numbers) also this is so cursed & I love it lol

@pietro-lopes
Copy link
Contributor Author

@pietro-lopes could you grab a log of it crashing with the dep on my maven? I'll look into fixing that since people should be depending on the stable jars from the maven (release ones without build numbers) also this is so cursed & I love it lol

It is here:
https://github.com/Layers-of-Railways/Railway/blob/1.20/dev/common/src/main/java/com/railwayteam/railways/mixin/client/AccessorTrackBlockOutline.java

I added remap to false, and for what I know (little about mixin lol) remap should be false for everything it is NOT vanilla

About the error you can see here: architectury/architectury-mixin#7

@IThundxr
Copy link

@pietro-lopes could you grab a log of it crashing with the dep on my maven? I'll look into fixing that since people should be depending on the stable jars from the maven (release ones without build numbers) also this is so cursed & I love it lol

It is here: https://github.com/Layers-of-Railways/Railway/blob/1.20/dev/common/src/main/java/com/railwayteam/railways/mixin/client/AccessorTrackBlockOutline.java

I added remap to false, and for what I know (little about mixin lol) remap should be false for everything it is NOT vanilla

About the error you can see here: architectury/architectury-mixin#7

Hmm yeah that's weird, I'll try fixing that by defining the field the accessor is trying to get but I'm not sure why architectury is being like that though

@pietro-lopes
Copy link
Contributor Author

@pietro-lopes could you grab a log of it crashing with the dep on my maven? I'll look into fixing that since people should be depending on the stable jars from the maven (release ones without build numbers) also this is so cursed & I love it lol

It is here: https://github.com/Layers-of-Railways/Railway/blob/1.20/dev/common/src/main/java/com/railwayteam/railways/mixin/client/AccessorTrackBlockOutline.java
I added remap to false, and for what I know (little about mixin lol) remap should be false for everything it is NOT vanilla
About the error you can see here: architectury/architectury-mixin#7

Hmm yeah that's weird, I'll try fixing that by defining the field the accessor is trying to get but I'm not sure why architectury is being like that though

You mean explicit define the field? I tried that and didn't work (didn't rename the getLONG... tho)

@IThundxr
Copy link

🤔 yeah then this is most likely a architectury issue then if even that didn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants