You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here's a quick run down of outstanding issues from eyeballing the code. Please suggest omissions and corrections. I haven't really looked in depth yet.
Hardware test mode compile flags and instructions v0.80 legacy code need to be removed and the main loop refactored and the code refactored to comply with the new API and desktop GUI. (Addressed in PR Run-time hardware tests and other changes #38)
The hardware tests assume 16 solenoids. The tests need to be tried out on the KH270 which has 12 solenoids instead of 16.
There seems to be some code redundancy e.g. beep function.
The API needs to be changed in the desktop software in accordance with the changes made in the firmware. When that is done, it will be ready for testing.
Here's a quick run down of outstanding issues from eyeballing the code. Please suggest omissions and corrections.
I haven't really looked in depth yet.The API has been revised so that Test Mode can be set from the desktop. The desktop software commands to enter test mode have been implemented but there are no equivalent steps in the finite state machine (addressed in PR Created GUI, Classes, and machine states for run-time hardware test ayab-desktop#415) and
it does not log the serial outputthe GUI does not open a serial monitor (addressed in PR Created GUI, Classes, and machine states for run-time hardware test ayab-desktop#415).The firmware has not been updated to recognize the commands.Hardware test mode compile flags
and instructions v0.80 legacy codeneed to be removedand the main loop refactoredand the code refactored to comply with the new API and desktop GUI. (Addressed in PR Run-time hardware tests and other changes #38)The hardware tests assume 16 solenoids. The tests need to be tried out on the KH270 which has 12 solenoids instead of 16.There seems to be some code redundancy e.g. beep function.The text was updated successfully, but these errors were encountered: