Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run-time hardware tests and other changes #38

Merged
merged 17 commits into from
Aug 24, 2020

Conversation

t0mpr1c3
Copy link
Contributor

@t0mpr1c3 t0mpr1c3 commented Aug 16, 2020

Compiling with 100% test coverage, but not tested together with the desktop software yet.

To get the tests to run properly, I needed to update travis to Ubuntu focal.

Label: Feature
Milestone 1.0.0
Reference #37

@t0mpr1c3 t0mpr1c3 force-pushed the wip branch 4 times, most recently from e397e56 to b86970d Compare August 16, 2020 18:59
@dl1com
Copy link
Contributor

dl1com commented Aug 17, 2020

Wow...that's a really nice piece of work @t0mpr1c3 😮

@t0mpr1c3
Copy link
Contributor Author

Wow...that's a really nice piece of work @t0mpr1c3 😮

Thanks Chris. We are definitely making some progress. Let's thank @Sturla22 again for setting up the mock framework. I really feel this was such a massive step forward and has really set us up for success.

@t0mpr1c3
Copy link
Contributor Author

Just to give a bit of an overview on what I am attempting here:

In addition to the feature changes that need implementing, I am pulling apart the structure of the firmware from a hierarchy with everything incorporated into a global Knitter object and moving towards a collection of singleton global classes that interoperate through public interfaces.

There are two goals here:

  1. To move further towards a modular structure with standalone elements. This helps uncouple functions from their implementations making changes easier to implement. This would be helpful for example if there are performance concerns regarding position encoding, and we want to recode the interrupt routines in C or assembly. It would be difficult to achieve that using the old structure.

  2. Programming to the public interfaces should make mocking more straightforward. It is explicit which methods need to be mocked. Real and mock objects simply become different implementations of the interface.

@t0mpr1c3 t0mpr1c3 changed the title Run-time hardware tests (work in progress) Run-time hardware tests and other changes Aug 24, 2020
@t0mpr1c3
Copy link
Contributor Author

Ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants