EOL refactor prototype #183
Conversation
| @@ -75,7 +75,7 @@ enum class AYAB_API : unsigned char { | |||
| using AYAB_API_t = enum AYAB_API; | |||
|
|
|||
| // API constants | |||
| constexpr uint8_t INDSTATE_LEN = 10U; | |||
| constexpr uint8_t INDSTATE_LEN = 12U; | |||
There was a problem hiding this comment.
- Please update the API description in ayab-manual accordingly
- Is there a change on the desktop side required as well to be compatible to this?
There was a problem hiding this comment.
Changes are also required in the documentation of the API https://github.com/AllYarnsAreBeautiful/ayab-manual/blob/1.0.0-dev/docs/API.md
| @@ -51,15 +51,72 @@ void Encoders::encA_interrupt() { | |||
| * \brief Read hall sensor on left and right. | |||
| * \param pSensor Which sensor to read (left or right). | |||
| */ | |||
| uint16_t Encoders::getHallValue(Direction_t pSensor) { | |||
| HallState_t Encoders::getHallValue(Direction_t pSensor) { | |||
There was a problem hiding this comment.
As a HallState is return from now on, we could rename the method to getHallState instead of getHallValue.
There was a problem hiding this comment.
Sure, I think that makes sense.
|
Is @jpcornil-git going to create a PR for his new async encoder code? |
Consensus was no in the meeting IIRC |
What do you think?
The main idea is to remove the filtering from the encoder code, and instead only work with a new enum HallState which indicates if the hall sensor is inactive, north, or south. This successfully builds for both Uno and ESP32 environments. I still need to check if I associated the right transitions to the right carriages.
I have also snuck in a small change here to the ayab-esp32 board definition of PIO, changing partition to "default.csv" as the reference board I took it from was outdated.