Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemic changes to support garter carriage on the full bed #196

Merged
Merged
Changes from 16 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
60d299e
Start G-carriage earlier to avoid overflowing m_position
clholgat Jul 31, 2024
efefaf1
Cleanup
clholgat Jul 31, 2024
702e55b
Whitespace
clholgat Jul 31, 2024
f273377
Rethink how solenoids are calculated
clholgat Aug 18, 2024
1d0d6cf
Finally works
clholgat Aug 25, 2024
600d0e3
Cleanup
clholgat Aug 25, 2024
b013100
Fix knit carriage belt shift
clholgat Aug 25, 2024
5f24490
Update offsets
clholgat Aug 25, 2024
2d56775
Belt shift experimentation
clholgat Aug 27, 2024
20bbb23
Fix Right to Left
clholgat Aug 27, 2024
d28c392
It works
clholgat Aug 30, 2024
fe3a180
Fix lace carriage
clholgat Aug 30, 2024
9bcfd16
Remove unused variable
clholgat Aug 30, 2024
fc9ba8c
Start G-carriage earlier to avoid overflowing m_position
clholgat Jul 31, 2024
b490d6f
Cleanup
clholgat Jul 31, 2024
44f5b36
Whitespace
clholgat Jul 31, 2024
696b9b7
Rethink how solenoids are calculated
clholgat Aug 18, 2024
cdd1afd
Finally works
clholgat Aug 25, 2024
ba29a37
Cleanup
clholgat Aug 25, 2024
03149f7
Fix knit carriage belt shift
clholgat Aug 25, 2024
5560a08
Update offsets
clholgat Aug 25, 2024
e99ebeb
Belt shift experimentation
clholgat Aug 27, 2024
95c11ae
Fix Right to Left
clholgat Aug 27, 2024
4d7b11b
It works
clholgat Aug 30, 2024
ea8733f
Fix lace carriage
clholgat Aug 30, 2024
b309e39
Remove unused variable
clholgat Aug 30, 2024
284371b
Update src/ayab/encoders.cpp
dl1com Aug 30, 2024
67affda
Update src/ayab/encoders.cpp
dl1com Aug 30, 2024
030c5f3
Fixed existing tests, removed the ones that are no longer relevant
clholgat Aug 31, 2024
52cd583
Merge branch 'clholgat/garter_carriage' of https://github.com/clholga…
clholgat Sep 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/ayab/knitter.cpp
Original file line number Diff line number Diff line change
@@ -396,7 +396,6 @@ bool Knitter::calculatePixelAndSolenoid() {
// magic numbers from machine manual
case Direction_t::Right:
startOffset = getStartOffset(Direction_t::Left);


// The Lace carriage is special
// See page 7 of the 930 service manual https://mkmanuals.com/downloadable/download/sample/sample_id/27/