-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce test_e2e #206
base: main
Are you sure you want to change the base?
introduce test_e2e #206
Conversation
84c017b
to
849cd02
Compare
The goal is to test the AYAB firmware at a higher level by looking at the Arduino interactions instead of mocking parts of the firmware.
358cab4
to
e9276b9
Compare
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
7793c12
to
5e5fefa
Compare
The goal is to test the AYAB firmware at a higher level by looking at the Arduino interactions instead of mocking parts of the firmware.
This is a test-only PR: it does not change any code in the built firmware. The few alterations made to files outside the
test
subdirectory are removing test-specific overrides so that more of the code can be tested.This involves creating a realistic model of a knitting machine's behavior, so that for example a test can simulate moving a carriage over a position sensor and the model will accurately simulate the encoder pulses and sensor values.
In this PR, the
KnittingMachine
class implements this model. Its own test suite (intest_knitting_machine.cpp
), unrelated to the AYAB firmware, consists of tests that can be reproduced on a real machine to confirm the model's accuracy.Still to do before review: