Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kicad and gerber versions of shield design #39

Merged
merged 7 commits into from
Jan 5, 2025

Conversation

vthunder
Copy link
Contributor

No description provided.

…lso add gerber and drill exports for fabrication.
@vthunder vthunder marked this pull request as draft July 16, 2024 06:40
vthunder added 3 commits July 16, 2024 00:08
Now features:
* A linked schematic matching the Eagle one except cosmetic or Kicad specific requirements (e.g., power flags).
* References have been hidden and labels placed to match the Eagle ones, which are incompatible with Kicad.
* Cosmetic changes in schematic and layout to account for font, etc differences.
* Version updated to "1.4TH Rev A" to make it clear it's a new variant--though should be functionally the same.
@vthunder vthunder marked this pull request as ready for review August 13, 2024 03:51
@dl1com
Copy link
Contributor

dl1com commented Sep 23, 2024

@VIPQualityPost would you mind to take a short view on this PR?

@VIPQualityPost
Copy link
Contributor

The layout of directory does not make a ton of sense to me. We should try to re-sort it so that there is a single directory for all files related to the KiCad parts and a different one related to the Eagle parts (do we need to even keep these around @dl1com ? They are retained in version control, nobody is using Eagle anymore and these files are probably bitrotted anyway)

Schematic:
The symbols in schematic have not really been 'updated' to KiCad symbols, which to me is fine, but I do think it's problematic that the manufacturing information is not included in the fields, we need to include a field for part vendor, part number at the minimum (to ID headers, ICs, etc). Ideally also a mouser or digikey part number.
Screenshot 2024-09-28 at 7 54 14 PM

PCB:
It might be nice on silkscreen layer to indicate what connectors are for what models, it seems a common issue when assembling the board that users are confused and making incorrect choices, but the manual/build instruction also maybe could be a bit clearer.

There also was a comment from @jonathanperret this week in Discord about accidentally marring the board during assembly causing short from +15V to +5V, killing Arduino. I don't think it makes much sense to have a pour for +5V , especially on an outer layer, we might want to just fix this now so that in the future it's not problems for anyone (the action requested here being that the pour on top layer is changed to GND net instead of +5V, and that the pour clearance increased from 0.4mm to something larger, maybe 0.75mm.)

Overall looks great, thanks for the contributions!

@dl1com
Copy link
Contributor

dl1com commented Jan 1, 2025

@vthunder

As @VIPQualityPost indicated, please:

  • remove Eagle related stuff, as it is preserved in version control anyway
  • take care to maintain manufacturer part# field, so it is clear which part to order (or at least have an example#)

The other improvements pointed out by @VIPQualityPost are definitely sensible changes, but should be handled in separate PRs.
If you could take care of these as well, it would be great!

HNY

… folder structure

Minor cleanup for latest KiCad version
Add part numbers to symbols
@vthunder
Copy link
Contributor Author

vthunder commented Jan 3, 2025

HNY everyone! And apologies for letting this PR sit for so long.

My last commit cleans up the folder to leave only the KiCad version, gerber exports, and the pdf for the power connector -- similar to the esp32 structure and should be much easier to navigate.

I also added part numbers for as many things as possible. I used multiple fields for when there is a choice (for 910/950 vs 930 connectors). Unfortunately I couldn't find a good way of including things in the BOM that don't have a footprint, like the buzzer or extension cable. So that needs to remain in the documentation.

Screenshot 2025-01-03 at 12 28 54 AM

I'm leaving the silkscreen fixes and the GND pour change for another PR, so that we can merge this sooner.

@dl1com
Copy link
Contributor

dl1com commented Jan 5, 2025

I also added part numbers for as many things as possible. I used multiple fields for when there is a choice (for 910/950 vs 930 connectors). Unfortunately I couldn't find a good way of including things in the BOM that don't have a footprint, like the buzzer or extension cable. So that needs to remain in the documentation.

For these parts, we could use the "exclude from board" flag which was introduced in KiCAD 7.x:
https://forum.kicad.info/t/components-to-be-added-to-bom-but-no-footprint/37139

I don't know if you want to add this to the PR as well...if not, we'll spare this for another Issue/PR.

I'm leaving the silkscreen fixes and the GND pour change for another PR, so that we can merge this sooner.

Please open two issues for this so we don't loose track of these.

Thanks again for your contribution!

@VIPQualityPost
Copy link
Contributor

Considering the actual BOM is unchanged, and we don't have any place formally assembling, I think the BOM is fine to keep as-is. I can fix it when we fix the right-hand EOL stuff in a bit.
All looks good to me!

@VIPQualityPost VIPQualityPost merged commit 2656d99 into AllYarnsAreBeautiful:main Jan 5, 2025
@vthunder
Copy link
Contributor Author

vthunder commented Jan 6, 2025

Thanks for merging!

Re: exclude from board, I found that post as well and tried to do it, but I still ended up with a footprint (and net). I even started to modify footprints to remove inputs/outputs and decided I was clearly doing something wrong.

Maybe I was using the wrong flag? I think there were some similar ones imported from eagle (like “dnp”).

In any case, happy to do a follow up for that once I learn how to do it properly. Will file some issues to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants