-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4291 centralize check of web connectivity #4293
Merged
EricClaeys
merged 15 commits into
v2024.12.06_01
from
4291-centralize-check-of-web-connectivity
Feb 5, 2025
Merged
4291 centralize check of web connectivity #4293
EricClaeys
merged 15 commits into
v2024.12.06_01
from
4291-centralize-check-of-web-connectivity
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It holds all the centralized "check" functions used by multiple scripts.
…colors() This allows other scripts to call remove_colors().
And use DIALOG_NC instead of DIALOG_NORMAL to be consistent with other functions
…kFunctions.sh Plus several other improvements.
Use FROM instead of FROM_INSTALL to make it more general.
This allows other values in FROM. Also, add placeholder code to check web connectivity in addition to checking ability to upload to remote Website or server. That code needs testing before making it official.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
makeChanges.sh
to test connectivity to a remote Website or server the same way thatremoteWebsiteInstall.sh
does.