Add process subcommands for multiple machines #17861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cli/ folder containing golang code - Add script to compile code to executable in build/cli/build-cli.sh - Add entrypoint script for development in bin/cli.sh - Add build profile to build the CLI as part of tha maven build via `-PgoCli` - Add `conf` service, consisting of - `bin/cli.sh conf get` as an example command, equivalent to `bin/alluxio getConf` - `bin/cli.sh conf log --name fully.qualified.class.path`, equivalent to `bin/alluxio fsadmin logLevel --logName fully.qualified.class.path` See Alluxio#17522 for more background info pr-link: Alluxio#17532 change-id: cid-9e3bf70e1a20848e2e4ec59b08b3de00bebc527d
dev docs for defining conventions for the new alluxio cli in golang see Alluxio#17522 pr-link: Alluxio#17530 change-id: cid-12886237cf2135b3a8c37d6b0ffa01ff6aaa6d92
- Add commands to start/stop individual processes, ex. `bin/cli.sh process start master` - Define process interface and registry - process specific java opts are defined with the process and are dynamically added to env - Add journal format command as part of starting master process - Mount options for worker are not ported because they will be deprecated in the near future continues to address Alluxio#17522 pr-link: Alluxio#17561 change-id: cid-1df162d6909669fa0c5a1e3449e5141d1e86ed06
Adds `info` subcommand, which contains: - `cache`: worker capacity information, calls the existing `bin/alluxio fsadmin report capacity` command - `collect`: collects cluster information into a single tarball, calls the existing `bin/alluxio collectInfo` command - `master`: master quorum information, calls the existing `bin/alluxio fs masterInfo` command - `report`: cluster information, calls the existing `bin/alluxio fsadmin report` command, excluding the `capacity` category Alluxio#17522 pr-link: Alluxio#17566 change-id: cid-2483fdb693f1572b0bf9c798503ea9cfd8e52b1d
Add journal commands to CLI as part of Alluxio#17522 pr-link: Alluxio#17569 change-id: cid-5b23a8a36c129fc609d30fcfe5469c7ef9aefc51
Add quorum/HA related commands as part of Alluxio#17522 pr-link: Alluxio#17570 change-id: cid-e9c76998b8fbfd023e0898c876cc495801a87fc5
Add fs commands to golang CLI as part of Alluxio#17522 unlike other CLI commands, utilize arguments to maintain the existing structure of filesystem commands (ex. cp, du, ls, mv, rm, etc) pr-link: Alluxio#17580 change-id: cid-c1d0d86604679d62fee214b9f9c0e20cd052e164
|
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
twalluxio
changed the title
|
Automated checks report:
All checks passed! |
twalluxio
force-pushed
the
golangCli-rsnyc
branch
from
b8720f5
to
409d615
Compare
twalluxio
force-pushed
the
golangCli-rsnyc
branch
from
409d615
to
fdf3801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add process commands with multiple machines to golang CLI as part of #17522
bin/alluxio-start.sh masters->bin/cli.sh process start mastersbin/alluxio-start.sh job_masters->bin/cli.sh process start job_mastersbin/alluxio-start.sh workers->bin/cli.sh process start workersbin/alluxio-start.sh job_workers->bin/cli.sh process start job_workersbin/alluxio-start.sh proxies->bin/cli.sh process start proxiesbin/alluxio-start.sh all->bin/cli.sh process start allbin/alluxio-start.sh local->bin/cli.sh process start localbin/alluxio-stop.sh masters->bin/cli.sh process stop mastersbin/alluxio-stop.sh job_masters->bin/cli.sh process stop job_mastersbin/alluxio-stop.sh workers->bin/cli.sh process stop workersbin/alluxio-stop.sh job_workers->bin/cli.sh process stop job_workersbin/alluxio-stop.sh proxies->bin/cli.sh process stop proxiesbin/alluxio-stop.sh all->bin/cli.sh process stop allbin/alluxio-stop.sh local->bin/cli.sh process stop localFor command process start on multiple machines, using crypto's ssh package to create an SSH session, connect to all machines, then send according subcommand on single machine to these machines.
PR design complete, pending tests...