Fix S3 CompleteMultipartUpload and add related UTs #17874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
007DXR
changed the title
007DXR
force-pushed
the
multipartupload
branch
2 times, most recently
from
520eea5
to
17091b3
Compare
…pload # Conflicts: # dora/tests/src/test/java/alluxio/client/rest/RestApiTest.java
007DXR
changed the title
007DXR
changed the title
007DXR
changed the title
|
@Jackson-Wang-7 ask for review |
Jackson-Wang-7
requested changes
Aug 15, 2023
dora/core/server/proxy/src/main/java/alluxio/proxy/s3/ListMultipartUploadsResult.java
Outdated
Show resolved
Hide resolved
dora/core/server/proxy/src/main/java/alluxio/proxy/s3/CompleteMultipartUploadRequest.java
Show resolved
Hide resolved
dora/core/server/proxy/src/main/java/alluxio/proxy/s3/CompleteMultipartUploadHandler.java
Outdated
Show resolved
Hide resolved
dora/core/server/proxy/src/main/java/alluxio/proxy/s3/S3ObjectTask.java
Outdated
Show resolved
Hide resolved
dora/core/server/proxy/src/main/java/alluxio/proxy/s3/S3RestUtils.java
Outdated
Show resolved
Hide resolved
dora/tests/src/test/java/alluxio/client/rest/S3ClientRestApiTest.java
Outdated
Show resolved
Hide resolved
pkuweblab
force-pushed
the
multipartupload
branch
from
d4051ec
to
6dc8ed2
Compare
dora/core/server/proxy/src/main/java/alluxio/proxy/s3/ListMultipartUploadsResult.java
Show resolved
Hide resolved
|
can be closed? |
apc999
force-pushed
the
main
branch
2 times, most recently
from
2fec0ec
to
b597c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
alluxio.proxy.s3.S3ObjectTask.CompleteMultipartUploadTask#validatePartsCompleteMultipartUploadexecutes the specified parts with the specified upload ID rather than all parts.initiate / complete / abort MPU and upload partunit tests.XAttrWhy are the changes needed?
there are problems in validateParts() of complete MPU
we need to fix validateParts() of complete MPU to keep s3 proxy behaviors as consistent with aws as possible.
Does this PR introduce any user facing changes?
can't get the bucket name and object name of the part while executing ListMultipartUploads
now complete MPU's response is like