Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused stressbench #17981

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

apc999
Copy link
Contributor

@apc999 apc999 commented Aug 13, 2023

What changes are proposed in this pull request?

Remove unused stressbench

Why are the changes needed?

With architecture after 300, a set of stressbench are no longer relevant.

Does this PR introduce any user facing changes?

Removed StressJobServiceBench, RpcBench, StressMasterBench, MaxFileBench, GetPinnedFileIdsBench, CompactionBench and FuseIOBench

@apc999 apc999 force-pushed the cleanup_stressbench branch 4 times, most recently from d762438 to a5c05cc Compare August 14, 2023 06:16
Copy link
Contributor

@jiacheliu3 jiacheliu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 comments. Thanks!

* Unit tests for {@link BlockMaster}.
*/
public class BlockMasterTest {
public static final long CAPACITY = 20L * 1024 * 1024 * 1024; // 20GB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleting this test belongs to a separate PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. removed this deletion from this PR

@@ -209,6 +209,13 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@apc999
Copy link
Contributor Author

apc999 commented Aug 14, 2023

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@apc999 apc999 added the type-debt This issue is about tech debt label Aug 14, 2023
@apc999
Copy link
Contributor Author

apc999 commented Aug 14, 2023

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit fb9b05e into Alluxio:main Aug 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-debt This issue is about tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants