-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused stressbench #17981
Remove unused stressbench #17981
Conversation
d762438
to
a5c05cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 comments. Thanks!
* Unit tests for {@link BlockMaster}. | ||
*/ | ||
public class BlockMasterTest { | ||
public static final long CAPACITY = 20L * 1024 * 1024 * 1024; // 20GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleting this test belongs to a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call. removed this deletion from this PR
dora/tests/pom.xml
Outdated
@@ -209,6 +209,13 @@ | |||
<version>${project.version}</version> | |||
<scope>test</scope> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
a5c05cc
to
0087e42
Compare
alluxio-bot, merge this please |
merge failed: |
alluxio-bot, merge this please |
What changes are proposed in this pull request?
Remove unused stressbench
Why are the changes needed?
With architecture after 300, a set of stressbench are no longer relevant.
Does this PR introduce any user facing changes?
Removed StressJobServiceBench, RpcBench, StressMasterBench, MaxFileBench, GetPinnedFileIdsBench, CompactionBench and FuseIOBench