Support unmount and remount in one atomic operation #17984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenoudet
suggested changes
Aug 14, 2023
core/server/master/src/main/java/alluxio/master/file/DefaultFileSystemMaster.java
Outdated
Show resolved
Hide resolved
|
@jenoudet Thanks for your review, PTAL. |
jiacheliu3
requested changes
Sep 2, 2023
| MountInfo mountInfo = mMountTable.getMountTable().get(alluxioPath.getPath()); | ||
| Map<String, String> propertyMap = context.getOptions().getPropertiesMap(); | ||
| if (mountInfo != null && propertyMap != null | ||
| && Boolean.parseBoolean(propertyMap.get("remount"))) { |
There was a problem hiding this comment.
per our discussion, let's change this to a new option in mount command
jiacheliu3
requested changes
Sep 8, 2023
core/server/master/src/main/java/alluxio/master/file/DefaultFileSystemMaster.java
Show resolved
Hide resolved
core/server/master/src/main/java/alluxio/master/file/DefaultFileSystemMaster.java
Show resolved
Hide resolved
Co-authored-by: Jiacheng Liu <[email protected]>
|
@jiacheliu3 Thank you for the review, PTAL |
maobaolong
changed the title
jiacheliu3
added
area-shell
jiacheliu3
changed the title
jiacheliu3
added
the
breaks-compatibility
|
alluxio-bot, merge this please |
alluxio-bot
added a commit
that referenced
this pull request
Nov 8, 2023
### What changes are proposed in this pull request? Merge missing commits from master-2.x to main. The commits in 2023/07/01~2023/11/08 from main...master-2.x will be included by this PR. We do this merge to catch missing fixes from `master-2.x` and catch the train before `main` cuts a release. #17747 is not cherry picked because tencent cloud EMR doc is removed #17755 is not cherry picked because DistLoadCliRunner has been removed in 3.x #17758 is not cherry picked because MonoBlockStore has been removed in 3.x #17641 is not cherry picked because the PR has already been in main #17781 is not cherry picked because the PR has already been in main #17722 is not cherry picked because the alluxio-fuse command has been changed a lot #17489 is not cherry picked because audit log on master is no longer in 3.x #17865 is not cherry picked because replication on job service is no longer in 3.x #17858 is not cherry picked because it is already in main #18090 is not cherry picked because generate-tarball has been rewritten in 3.x #18091 is not cherry picked because the change is already in main #17474 is not cherry picked because reconfiguration feature is not defined in 3.x #17735 is not cherry picked because MonoBlockStore is no longer in 3.x #18133 is not cherry picked because the issue is about master metadata and no longer relevant in 3.x #17910 is not cherry picked because I prefer to do that manually #17983 is not cherry picked because the web UI has been reworked #17984 is not cherry picked because Mount/Unmount commands have been reworked in 3.x #18103 is not cherry picked because worker cache metrics have been reworked in 3.x #18185 is not cherry picked because the report command has been reworked in 3.x #18222 is not cherry picked because Mount/Unmount operations have been reworked in 3.x #18143 is not cherry picked because the change is already in main #18303 is not cherry picked because the change is already in main #18208 is not cherry picked because cache metrics have been reworked in 3.x #17002 is not cherry picked because the owner has been notified separately #18334 is not cherry picked because the bash scripts have been reworked in 3.x #18326 is not cherry picked because the owner has been notified separately pr-link: #18397 change-id: cid-dbf8cbb2d9e721a5a0a1e5028a3c9577438a2ac0
maobaolong
added a commit
to maobaolong/alluxio
that referenced
this pull request
Jan 3, 2024
### What changes are proposed in this pull request? Support unmount and mount to another mount point within the same lock ### Why are the changes needed? Support replace ufs for a mount point. The operation is atomic so no user operations should fail due to observing the middle state. ### Does this PR introduce any user facing changes? A new rpc field and cmd options are added. pr-link: Alluxio#17984 change-id: cid-d96b4df7d24ab1082e46e6d5a72563534714a48f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Support unmount and mount to another mount point within the same lock
Why are the changes needed?
Support replace ufs for a mount point. The operation is atomic so no user operations should fail due to observing the middle state.
Does this PR introduce any user facing changes?
A new rpc field and cmd options are added.