Remove MetaMasterConfigClient initialization in the client #18012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where should the clients get their config from instead, if this change is merged? |
The client only reads local config file so far. |
dbw9580
reviewed
Aug 17, 2023
| /** | ||
| * Integration tests for path level configurations. | ||
| */ | ||
| public class PathConfigurationIntegrationTest { |
There was a problem hiding this comment.
why is this integration test removed?
There was a problem hiding this comment.
PathConfig is already removed
dbw9580
approved these changes
Aug 17, 2023
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove MetaMasterConfigClient initialization in the client.
Why are the changes needed?
Remove MetaMasterConfigClient initialization in the client.
Does this PR introduce any user facing changes?
NA