Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PagedDoraWorkerTest.java #18050

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Update PagedDoraWorkerTest.java #18050

merged 1 commit into from
Aug 23, 2023

Conversation

thu-david
Copy link
Contributor

update Rename and exists tests for PagedDoraWorker.

What changes are proposed in this pull request?

I have added two unit test for PagedDoraWorker.

Why are the changes needed?

Please clarify why the changes are needed. For instance,

  1. One function for test Rename in PagedDoraWorker.
    2.One function for test Exists in PagedDoraWorker.

Does this PR introduce any user facing changes?

No

update Rename and exists tests for PagedDoraWorker.
public void testRename() throws IOException, AccessControlException {
File srcFolder = mTestFolder.newFolder("root");
String rootPath = srcFolder.getAbsolutePath();
mWorker.rename(rootPath, rootPath + "2", RenamePOptions.getDefaultInstance());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use PathUtils.concatPath() instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,I wil

@elega elega added the type-code-quality code quality improvement label Aug 23, 2023
Copy link
Contributor

@elega elega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elega
Copy link
Contributor

elega commented Aug 23, 2023

alluxio-bot, merge this please.

@alluxio-bot alluxio-bot merged commit c58355f into Alluxio:main Aug 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-code-quality code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants