Fix getConf bugs when it comes across warning #18330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YichuanSun
commented
Oct 26, 2023
jiacheliu3
reviewed
Oct 27, 2023
| else | ||
| result="false" | ||
| fi | ||
| echo $result |
| else | ||
| result="false" | ||
| fi | ||
| echo $result |
There was a problem hiding this comment.
Actually I don't think it can be removed. If we delete echo, the function will use a temporary parameter "result" to store the boolean value, after returning, the result will not exist.
|
Also you should submit the PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
As issue #15795 mentioned. When output any warnings, the cli of judging HA_ENABLED will be invalid. This PR fixs it.
Why are the changes needed?
Bug fix.
Does this PR introduce any user facing changes?
No.