Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DoraLoadCommandIntegrationTest #18504

Merged

Conversation

secfree
Copy link
Contributor

@secfree secfree commented Feb 1, 2024

What changes are proposed in this pull request?

Fix DoraLoadCommandIntegrationTest.

Why are the changes needed?

Without this PR, DoraLoadCommandIntegrationTest may fail with the following exception

[ERROR] alluxio.client.cli.fs.command.DoraLoadCommandIntegrationTest.testCommand  Time elapsed: 7.995 s  <<< FAILURE!
java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at alluxio.client.cli.fs.command.DoraLoadCommandIntegrationTest.testCommand(DoraLoadCommandIntegrationTest.java:107)

The cause is that

  • The second job is using the same path as the first job

  • While submitting the second job, the second job is still in "cleaning" state. As the following log shows

    2024-01-31 09:52:33,057 [master-rpc-executor-TPE-thread-494] WARN  scheduler.Scheduler (Scheduler.java:submitJob) - There's concurrent submit while job is still in cleaning state
    
  • "progress" returns the progress of the first job instead of the second one

The PR changes to use a different path for the second job, which avoids this issue.

Does this PR introduce any user facing changes?

NO

@jja725 jja725 self-requested a review February 1, 2024 03:51
Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jja725 jja725 added the type-bug This issue is about a bug label Feb 1, 2024
@jja725
Copy link
Contributor

jja725 commented Feb 1, 2024

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 07ec4b9 into Alluxio:main Feb 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug This issue is about a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants