reuse already existing functions

Alokih · Nov 18, 2024 · e433a09 · e433a09
1 parent 660e73a
commit e433a09
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/cypress/e2e/facility_spec/FacilityCreation.cy.ts b/cypress/e2e/facility_spec/FacilityCreation.cy.ts
@@ -59,11 +59,6 @@ describe("Facility Creation", () => {
   const triageErrorMessage = ["This field is required"];
   const facilityType = "Primary Health Centres";
 
-  const nonAdminUsers = [
-    { username: "dummynurse1", password: "Coronasafe@123" },
-    { username: "devdoctor", password: "Coronasafe@123" },
-  ];
-
   before(() => {
     loginPage.loginAsDistrictAdmin();
     cy.saveLocalStorage();
@@ -340,13 +335,18 @@ describe("Facility Creation", () => {
   });
 
   it("Access Restriction for Non-Admin Users to facility creation page", () => {
-    nonAdminUsers.forEach((user) => {
-      loginPage.login(user.username, user.password);
-      cy.visit("/facility/create");
+    const nonAdminLoginMethods = [
+      loginPage.loginAsDevDoctor.bind(loginPage),
+      loginPage.loginAsStaff.bind(loginPage),
+    ];
 
+    nonAdminLoginMethods.forEach((loginMethod) => {
+      loginMethod();
+      cy.visit("/facility/create");
       facilityPage.verifyErrorNotification(
         "You don't have permission to perform this action. Contact the admin",
       );
+      cy.clearCookies();
     });
   });
 

diff --git a/cypress/pageobject/Facility/FacilityCreation.ts b/cypress/pageobject/Facility/FacilityCreation.ts
@@ -51,7 +51,7 @@ class FacilityPage {
   }
 
   submitForm() {
-    cy.get("button#submit").click();
+    cy.submitButton("Save Facility");
   }
 
   selectBedType(bedType: string) {