Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade notarize and electron-updater
Browse files Browse the repository at this point in the history
Alphrag committed Oct 14, 2024
1 parent ba1ca6a commit c722a88
Showing 4 changed files with 90 additions and 31 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/builds.yml
Original file line number Diff line number Diff line change
@@ -5,6 +5,7 @@
# 'FERDIUM_PUBLISH_TOKEN' (A GitHub Personal Access Token with appropriate permissions - for publishing the built artifacts)
# 'APPLEID' (The username of your Apple developer account - for notarizing the mac artifacts)
# 'APPLEID_PASSWORD' (An app-specific password - for notarizing the mac artifacts)
# 'APPLE_TEAM_ID' (The TeamID in your Apple developer account - for notarizing the mac artifacts)
# 'CSC_LINK' (The HTTPS link or local path to certificate - for code signing of mac artifacts)
# 'CSC_KEY_PASSWORD' (The password to decrypt the certificate given in CSC_LINK - for code signing of mac artifacts)
# 'WIN_CSC_LINK' (The HTTPS link or local path to certificate - for code signing of windows artifacts)
@@ -207,6 +208,7 @@ jobs:
CSC_IDENTITY_AUTO_DISCOVERY: true
APPLEID: ${{ secrets.APPLEID }}
APPLEID_PASSWORD: ${{ secrets.APPLEID_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
run: pnpm build --publish always
2 changes: 1 addition & 1 deletion build-helpers/notarize.js
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ exports.default = async function notarizing(context) {
await notarize({
tool: 'notarytool',
appPath: `${appOutDir}/${appName}.app`,
teamId: '55E9FPJ93P',
teamId: process.env.APPLE_TEAM_ID || '',
appleId: process.env.APPLEID || '',
appleIdPassword: process.env.APPLEID_PASSWORD || '',
});
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@
"electron-dl": "3.5.2",
"electron-find": "1.0.7",
"electron-react-titlebar": "1.2.1",
"electron-updater": "6.2.1",
"electron-updater": "6.3.9",
"electron-window-state": "5.0.3",
"fast-folder-size": "2.2.0",
"fs-extra": "11.2.0",
@@ -135,7 +135,7 @@
"@biomejs/biome": "1.6.1",
"@commitlint/cli": "19.3.0",
"@commitlint/config-conventional": "19.2.2",
"@electron/notarize": "2.3.2",
"@electron/notarize": "2.5.0",
"@eslint-react/eslint-plugin": "1.5.12",
"@formatjs/cli": "6.2.12",
"@jest/types": "29.6.3",
113 changes: 85 additions & 28 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c722a88

Please sign in to comment.