Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with umpire in ascent_config.mk.in and dray_config.mk.in. #1463

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

brugger1
Copy link
Contributor

Umpire stores its libraries in a lib64 directory and the *config.mk.in files had lib. I changed the paths in the *config.mk.in files.

There was a typo in ascent_config.mk.in where ASCENT_UMPIRE_LIB_FLAGS was used instead of ASCENT_CAMP_LIB_FLAGS. I assume this was from a cut, paste and modify error.

There was a typo in dry_config.mk.in where DRAY_RAJA_DIR was used instead of DRAY_UMPIRE_DIR. I assume this was from a cut, paste and modify error.

@brugger1 brugger1 requested a review from cyrush February 20, 2025 00:19
@cyrush
Copy link
Member

cyrush commented Feb 20, 2025

thank you, I fixed this for the cmake case, but missed the config.mk case!

elseif(EXISTS ${UMPIRE_DIR}/lib64/cmake/umpire)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants