Skip to content

Commit

Permalink
remove added clickhouse-server:24.3 from CI/CD pipelines, wait when r…
Browse files Browse the repository at this point in the history
  • Loading branch information
Slach committed Mar 28, 2024
1 parent f863b3f commit 594da6d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ jobs:
- '22.8'
- '23.3'
- '23.8'
- '24.3'
# wait when resolve https://github.com/ClickHouse/ClickHouse/issues/62018
# - '24.3'
steps:
- name: Setup golang
id: setup-go
Expand Down Expand Up @@ -235,7 +236,8 @@ jobs:
- '22.8'
- '23.3'
- '23.8'
- '24.3'
# wait when resolve https://github.com/ClickHouse/ClickHouse/issues/62018
# - '24.3'
steps:
- name: Checkout project
uses: actions/checkout@v4
Expand Down
1 change: 0 additions & 1 deletion ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ IMPROVEMENTS
- added support of native Clickhouse incremental backup for `use_embedded_backup_restore: true` fix [735](https://github.com/Altinity/clickhouse-backup/issues/735)
- added `GCS_CHUNK_SIZE` config parameter, try to speedup GCS upload fix [874](https://github.com/Altinity/clickhouse-backup/pull/874), thanks @dermasmid
- switched to golang 1.22
- added `clickhouse-server:24.3` to CI/CD pipelines

BUG FIXES
- continue `S3_MAX_PARTS_COUNT` default value from `2000` to `4000` to continue decrease memory usage for S3
Expand Down
3 changes: 3 additions & 0 deletions pkg/backup/download.go
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,9 @@ func (b *Backuper) downloadTableMetadata(ctx context.Context, backupName string,
// downloadMissedInnerTablesMetadata - download, missed .inner. tables if materialized view query not contains `TO db.table` clause, https://github.com/Altinity/clickhouse-backup/issues/765
// @todo think about parallel download if sequentially will slow
func (b *Backuper) downloadMissedInnerTablesMetadata(ctx context.Context, backupName string, metadataSize uint64, tablesForDownload []metadata.TableTitle, tableMetadataAfterDownload []*metadata.TableMetadata, disks []clickhouse.Disk, schemaOnly bool, partitions []string, log *apexLog.Entry) ([]*metadata.TableMetadata, []metadata.TableTitle, uint64, error) {
if b.isEmbedded {
return tableMetadataAfterDownload, tablesForDownload, metadataSize, nil
}
for _, t := range tableMetadataAfterDownload {
if t == nil {
continue
Expand Down

0 comments on commit 594da6d

Please sign in to comment.