Skip to content

Commit

Permalink
use native_copy instead of allow_s3_native_copy for 23.3
Browse files Browse the repository at this point in the history
  • Loading branch information
Slach committed Jun 11, 2024
1 parent f6db4e3 commit a6042fa
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/backup/backuper.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,11 @@ func (b *Backuper) isDiskTypeEncryptedObject(disk clickhouse.Disk, disks []click
func (b *Backuper) getEmbeddedBackupDefaultSettings(version int) []string {
settings := []string{}
if b.cfg.General.RemoteStorage == "s3" || b.cfg.General.RemoteStorage == "gcs" {
settings = append(settings, "allow_s3_native_copy=1")
if version > 23007001 {
settings = append(settings, "allow_s3_native_copy=1")
} else {
settings = append(settings, "native_copy=1")
}
}
if b.cfg.General.RemoteStorage == "azblob" && version >= 24005001 {
settings = append(settings, "allow_azure_native_copy=1")
Expand Down

0 comments on commit a6042fa

Please sign in to comment.