Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update clickhouse-backup docker args example #1000

Merged

Conversation

christopherdeutsch
Copy link
Contributor

@christopherdeutsch christopherdeutsch commented Aug 29, 2024

Hi! I think one of the examples can be simplified.

The current command in the example for clickhouse-backup is

 command:
    - bash
    - -xc
    - "/bin/clickhouse-backup server"

And the Dockerfile ends with:

ENTRYPOINT ["/entrypoint.sh"]
CMD [ "/bin/clickhouse-backup", "--help" ]

This PR will update the docs to just pass server to the entrypoint script, since bash is unnecessary. The -xc flags could be useful for debugging, but I propose that using the args to specify server makes the example more clear.

Examples.md Outdated Show resolved Hide resolved
@Slach
Copy link
Collaborator

Slach commented Sep 5, 2024

thanks for contribution

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10720629068

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on deutsch/example_docker_args at 65.757%

Totals Coverage Status
Change from base Build 10720587739: 65.8%
Covered Lines: 8816
Relevant Lines: 13407

💛 - Coveralls

@Slach Slach merged commit f9ff98c into Altinity:master Sep 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants