Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect max_parts_count #740

Merged
merged 1 commit into from
Sep 7, 2023
Merged

respect max_parts_count #740

merged 1 commit into from
Sep 7, 2023

Conversation

rodrigargar
Copy link
Contributor

Fix #739

Slach
Slach requested changes Sep 5, 2023
View reviewed changes
pkg/storage/general.go Show resolved Hide resolved
pkg/storage/s3.go
if partSize < 5*1024*1024 {
partSize = 5 * 1014 * 1024
partSize = 5 * 1024 * 1024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

pkg/storage/s3.go Show resolved Hide resolved
@Slach
Copy link
Collaborator

Slach commented Sep 7, 2023

could you merge latest master to your branch?

@rodrigargar rodrigargar force-pushed the respect-s3-max-parts-count branch from fdff13b to 0504c8f Compare September 7, 2023 15:50
@Slach Slach added this to the 2.4.1 milestone Sep 7, 2023
@Slach Slach merged commit 76e1e08 into Altinity:master Sep 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slach Slach Slach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

S3 max_parts_count not respected may result in TotalPartsExceeded
2 participants
@rodrigargar @Slach